fix(slack): default absent appType to custom at deploy; deactivate custom-bot webhooks on credential delete

- appType is hidden and seeded 'custom' by value(), which only covers
  editor-created blocks; defaultValue now persists it via buildProviderConfig
  and the deploy fallback flips to custom (the only exposed mode this ship)
- deleting a slack-custom-bot credential now also deactivates provider='slack'
  webhooks routed by that credential id, not just native slack_app rows

Author: TheodoreSpeaks

apps/sim/lib/credentials/deletion.ts

@@ -2,7 +2,7 @@ import { AuditAction, AuditResourceType, recordAudit } from '@sim/audit'
 import { db } from '@sim/db'
 import * as schema from '@sim/db/schema'
 import { createLogger } from '@sim/logger'
-import { and, eq, sql } from 'drizzle-orm'
+import { and, eq, or, sql } from 'drizzle-orm'
 import type { NextRequest } from 'next/server'
 import { CREDENTIAL_SUBBLOCK_IDS } from '@/lib/workflows/persistence/utils'
 
@@ -95,20 +95,26 @@ export async function clearCredentialRefs(
 }
 
 /**
- * Deactivates native Slack (`slack_app`) trigger webhooks bound to this
- * credential so inbound events stop routing once the account is disconnected.
- * The credential id lives in `providerConfig`, not a foreign key, so it is not
- * covered by CASCADE.
+ * Deactivates Slack trigger webhooks bound to this credential so inbound
+ * events stop routing once the account is disconnected: native (`slack_app`)
+ * rows reference it via `providerConfig.credentialId`, custom-bot (`slack`)
+ * rows via `routingKey` = the bot credential id. Neither is a foreign key, so
+ * neither is covered by CASCADE.
  */
 async function deactivateSlackAppWebhooks(credentialId: string): Promise<void> {
   await db
     .update(schema.webhook)
     .set({ isActive: false, updatedAt: new Date() })
     .where(
       and(
-        eq(schema.webhook.provider, 'slack_app'),
         eq(schema.webhook.isActive, true),
-        sql`${schema.webhook.providerConfig}->>'credentialId' = ${credentialId}`
+        or(
+          and(
+            eq(schema.webhook.provider, 'slack_app'),
+            sql`${schema.webhook.providerConfig}->>'credentialId' = ${credentialId}`
+          ),
+          and(eq(schema.webhook.provider, 'slack'), eq(schema.webhook.routingKey, credentialId))
+        )
       )
     )
 }

apps/sim/lib/webhooks/deploy.ts

@@ -430,7 +430,10 @@ export async function saveTriggerWebhooksForDeploy({
     let effectivePath: string | null = triggerPath
     let routingKey: string | null = null
     if (triggerId === 'slack_oauth') {
-      const appType = typeof providerConfig.appType === 'string' ? providerConfig.appType : 'sim'
+      // Absent appType means custom: it's the only mode this ship exposes (the
+      // hidden selector seeds/persists 'custom'), and defaulting to sim would
+      // send credential-less configs down the OAuth/team-id branch.
+      const appType = typeof providerConfig.appType === 'string' ? providerConfig.appType : 'custom'
       if (appType === 'sim') {
         const eventType =
           typeof providerConfig.eventType === 'string' ? providerConfig.eventType : null

apps/sim/triggers/slack/oauth.ts

@@ -73,6 +73,10 @@ export const slackOAuthTrigger: TriggerConfig = {
         { label: 'Custom', id: 'custom' },
       ],
       value: () => 'custom',
+      // `value()` only seeds editor-created blocks; `defaultValue` is what
+      // buildProviderConfig persists when the stored value is absent
+      // (imported / programmatically-created workflows).
+      defaultValue: 'custom',
       description: 'Use the official Sim Slack app, or your own custom Slack app.',
       mode: 'trigger',
     },