fix(files): suppress transient streaming preview errors for docx and pptx

Author: waleedlatif1

apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/docx-preview.tsx

@@ -6,12 +6,7 @@ import { toError } from '@sim/utils/errors'
 import { cn } from '@/lib/core/utils/cn'
 import type { WorkspaceFileRecord } from '@/lib/uploads/contexts/workspace'
 import { useWorkspaceFileBinary } from '@/hooks/queries/workspace-files'
-import {
-  PDF_PAGE_SKELETON,
-  PreviewError,
-  resolvePreviewError,
-  shouldSuppressStreamingDocumentError,
-} from './preview-shared'
+import { PDF_PAGE_SKELETON, PreviewError, resolvePreviewError } from './preview-shared'
 
 const logger = createLogger('DocxPreview')
 
@@ -136,12 +131,7 @@ export const DocxPreview = memo(function DocxPreview({
             setHasRenderedPreview(true)
           }
           const msg = toError(err).message || 'Failed to render document'
-          if (previousHtml || shouldSuppressStreamingDocumentError(msg)) {
-            logger.info('Suppressing transient DOCX streaming preview error', { error: msg })
-          } else {
-            logger.error('DOCX render failed', { error: msg })
-            setRenderError(msg)
-          }
+          logger.info('Transient DOCX streaming preview error (suppressed)', { error: msg })
         }
       } finally {
         if (!cancelled) {
@@ -157,17 +147,11 @@ export const DocxPreview = memo(function DocxPreview({
     }
   }, [streamingContent, workspaceId])
 
-  const error =
-    hasRenderedPreview && streamingContent !== undefined
-      ? null
-      : streamingContent !== undefined
-        ? renderError
-        : resolvePreviewError(fetchError, renderError)
+  const error = streamingContent !== undefined ? null : resolvePreviewError(fetchError, renderError)
   if (error) return <PreviewError label='document' error={error} />
 
   const showSkeleton =
-    !hasRenderedPreview &&
-    ((streamingContent !== undefined && rendering) || (streamingContent === undefined && isLoading))
+    !hasRenderedPreview && (streamingContent !== undefined || isLoading || rendering)
 
   return (
     <div className='relative h-full w-full overflow-auto bg-[var(--surface-1)]'>

apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/pptx-preview.tsx

@@ -6,11 +6,7 @@ import { toError } from '@sim/utils/errors'
 import { Skeleton } from '@/components/emcn'
 import type { WorkspaceFileRecord } from '@/lib/uploads/contexts/workspace'
 import { useWorkspaceFileBinary } from '@/hooks/queries/workspace-files'
-import {
-  PreviewError,
-  resolvePreviewError,
-  shouldSuppressStreamingDocumentError,
-} from './preview-shared'
+import { PreviewError, resolvePreviewError } from './preview-shared'
 
 const logger = createLogger('PptxPreview')
 
@@ -44,15 +40,6 @@ function pptxCacheKey(fileId: string, dataUpdatedAt: number, byteLength: number)
   return `${fileId}:${dataUpdatedAt}:${byteLength}`
 }
 
-function shouldSuppressStreamingPptxError(message: string): boolean {
-  return (
-    shouldSuppressStreamingDocumentError(message) ||
-    message.includes('SyntaxError: Invalid or unexpected token') ||
-    message.includes('PPTX generation cancelled') ||
-    message.includes('SyntaxError: Unexpected end of input')
-  )
-}
-
 function pptxCacheSet(key: string, slides: string[]): void {
   pptxSlideCache.set(key, slides)
   if (pptxSlideCache.size > 5) {
@@ -197,12 +184,7 @@ export function PptxPreview({
       } catch (err) {
         if (!cancelled && !(err instanceof DOMException && err.name === 'AbortError')) {
           const msg = toError(err).message || 'Failed to render presentation'
-          if (shouldSuppressStreamingPptxError(msg)) {
-            logger.info('Suppressing transient PPTX streaming preview error', { error: msg })
-          } else {
-            logger.error('PPTX render failed', { error: msg })
-            setRenderError(msg)
-          }
+          logger.info('Transient PPTX streaming preview error (suppressed)', { error: msg })
         }
       } finally {
         if (!cancelled) setRendering(false)
@@ -264,12 +246,12 @@ export function PptxPreview({
     }
   }, [fileData, streamingContent, cacheKey])
 
-  const error = resolvePreviewError(fetchError, renderError)
+  const error = streamingContent !== undefined ? null : resolvePreviewError(fetchError, renderError)
   const loading = isFetching || rendering
 
   if (error) return <PreviewError label='presentation' error={error} />
 
-  if (loading && slides.length === 0) {
+  if ((loading || streamingContent !== undefined) && slides.length === 0) {
     return PPTX_SLIDE_SKELETON
   }
 

apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/preview-shared.tsx

@@ -19,20 +19,6 @@ export function resolvePreviewError(
   return renderError
 }
 
-export function shouldSuppressStreamingDocumentError(message: string): boolean {
-  const lower = message.toLowerCase()
-  return (
-    lower.includes('preview failed') ||
-    lower.includes('aborterror') ||
-    lower.includes('unexpected end') ||
-    lower.includes('unexpected eof') ||
-    lower.includes('invalid or unexpected token') ||
-    lower.includes('end of central directory') ||
-    lower.includes('corrupted zip') ||
-    lower.includes('end of data reached')
-  )
-}
-
 export const PDF_PAGE_SKELETON = (
   <div className='absolute inset-0 flex flex-col items-center gap-4 overflow-y-auto bg-[var(--surface-1)] p-6'>
     {[0, 1].map((i) => (