Skip to content

Commit bec5bc6

Browse files
fix(logger): satisfy biome rules in new prod log tests
Co-authored-by: Theodore Li <TheodoreSpeaks@users.noreply.github.com>
1 parent 95705f1 commit bec5bc6

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

packages/logger/src/index.test.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -110,33 +110,33 @@ describe('Logger', () => {
110110
beforeEach(() => {
111111
originalNodeEnv = env.NODE_ENV
112112
originalLogLevel = env.LOG_LEVEL
113-
hadWindow = Object.prototype.hasOwnProperty.call(globalRecord, 'window')
113+
hadWindow = Object.hasOwn(globalRecord, 'window')
114114
originalWindow = globalRecord.window
115115
})
116116

117117
afterEach(() => {
118118
if (originalNodeEnv === undefined) {
119-
delete env.NODE_ENV
119+
env.NODE_ENV = undefined
120120
} else {
121121
env.NODE_ENV = originalNodeEnv
122122
}
123123

124124
if (originalLogLevel === undefined) {
125-
delete env.LOG_LEVEL
125+
env.LOG_LEVEL = undefined
126126
} else {
127127
env.LOG_LEVEL = originalLogLevel
128128
}
129129

130130
if (hadWindow) {
131131
globalRecord.window = originalWindow
132132
} else {
133-
delete globalRecord.window
133+
globalRecord.window = undefined
134134
}
135135
})
136136

137137
test('logs info by default in production on server', () => {
138138
env.NODE_ENV = 'production'
139-
delete env.LOG_LEVEL
139+
env.LOG_LEVEL = undefined
140140

141141
const logger = createLogger('ProdServer')
142142
logger.debug('debug message')
@@ -167,7 +167,7 @@ describe('Logger', () => {
167167

168168
test('does not log in production browser runtime', () => {
169169
env.NODE_ENV = 'production'
170-
delete env.LOG_LEVEL
170+
env.LOG_LEVEL = undefined
171171
globalRecord.window = {}
172172

173173
const logger = createLogger('ProdBrowser')

0 commit comments

Comments
 (0)