fix(academy): type safety fixes — null metadata fallbacks, returning() guard, exhaustive union, empty catch

Author: waleedlatif1

apps/sim/app/academy/(catalog)/certificate/[certificateNumber]/page.tsx

@@ -16,8 +16,8 @@ export async function generateMetadata({ params }: CertificatePageProps): Promis
   const certificate = await fetchCertificate(certificateNumber)
   if (!certificate) return { title: 'Certificate Not Found' }
   return {
-    title: `${certificate.metadata?.courseTitle} — Certificate`,
-    description: `Verified certificate of completion awarded to ${certificate.metadata?.recipientName}.`,
+    title: `${certificate.metadata?.courseTitle ?? 'Certificate'} — Certificate`,
+    description: `Verified certificate of completion awarded to ${certificate.metadata?.recipientName ?? 'a recipient'}.`,
   }
 }
 

apps/sim/app/academy/[courseSlug]/[lessonSlug]/components/lesson-quiz.tsx

@@ -31,6 +31,9 @@ function scoreQuiz(questions: QuizQuestion[], answers: Answers, passingScore: nu
       correct =
         selected.length === q.correctIndices.length &&
         selected.every((v) => q.correctIndices.includes(v))
+    } else {
+      const _exhaustive: never = q
+      void _exhaustive
     }
     return { correct, explanation: 'explanation' in q ? q.explanation : undefined }
   })

apps/sim/app/academy/components/lesson-video.tsx

@@ -47,7 +47,7 @@ function resolveEmbedUrl(url: string): string | null {
     }
 
     return null
-  } catch {
+  } catch (_e: unknown) {
     return null
   }
 }

apps/sim/app/api/academy/certificates/route.ts

@@ -115,6 +115,10 @@ export async function POST(req: NextRequest) {
       })
       .returning()
 
+    if (!certificate) {
+      return NextResponse.json({ error: 'Failed to issue certificate' }, { status: 500 })
+    }
+
     logger.info('Certificate issued', {
       userId: session.user.id,
       courseId,