fix(authz): enforce credential and workspace boundaries

Author: icecrasher321

apps/sim/app/api/mcp/servers/[id]/refresh/route.test.ts

@@ -5,31 +5,33 @@ import { dbChainMockFns, resetDbChainMock } from '@sim/testing'
 import type { NextRequest } from 'next/server'
 import { afterAll, beforeEach, describe, expect, it, vi } from 'vitest'
 
-const { mockClearCache, mockDiscoverServerTools } = vi.hoisted(() => ({
+const { mockClearCache, mockDiscoverServerTools, requiredRoles } = vi.hoisted(() => ({
   mockClearCache: vi.fn(),
   mockDiscoverServerTools: vi.fn(),
+  requiredRoles: [] as string[],
 }))
 
 vi.mock('@/lib/core/utils/with-route-handler', () => ({
   withRouteHandler: (handler: unknown) => handler,
 }))
 
 vi.mock('@/lib/mcp/middleware', () => ({
-  withMcpAuth:
-    () =>
-    (
+  withMcpAuth: (requiredRole: string) => {
+    requiredRoles.push(requiredRole)
+    return (
       handler: (
         request: NextRequest,
         context: { userId: string; workspaceId: string; requestId: string },
         routeContext: { params: Promise<{ id: string }> }
       ) => Promise<Response>
     ) =>
-    (request: NextRequest, routeContext: { params: Promise<{ id: string }> }) =>
-      handler(
-        request,
-        { userId: 'user-1', workspaceId: 'workspace-1', requestId: 'request-1' },
-        routeContext
-      ),
+      (request: NextRequest, routeContext: { params: Promise<{ id: string }> }) =>
+        handler(
+          request,
+          { userId: 'user-1', workspaceId: 'workspace-1', requestId: 'request-1' },
+          routeContext
+        )
+  },
 }))
 
 vi.mock('@/lib/mcp/service', () => ({
@@ -72,6 +74,10 @@ describe('MCP server refresh route', () => {
     resetDbChainMock()
   })
 
+  it('requires workspace write permission because refresh persists workflow changes', () => {
+    expect(requiredRoles).toEqual(['write'])
+  })
+
   it('preserves the service-persisted OAuth pending status', async () => {
     mockDiscoverServerTools.mockRejectedValueOnce(new Error('OAuth authorization required'))
 

apps/sim/app/api/mcp/servers/[id]/refresh/route.ts

@@ -158,7 +158,7 @@ async function syncToolSchemasToWorkflows(
 }
 
 export const POST = withRouteHandler(
-  withMcpAuth<{ id: string }>('read')(
+  withMcpAuth<{ id: string }>('write')(
     async (request: NextRequest, { userId, workspaceId, requestId }, { params }) => {
       try {
         const paramsValidation = mcpServerIdParamsSchema.safeParse(await params)

apps/sim/ee/workspace-forking/lib/create-fork.test.ts

@@ -91,7 +91,7 @@ vi.mock('@/lib/workspaces/policy', () => ({
 
 import { createFork } from '@/ee/workspace-forking/lib/create-fork'
 
-const SOURCE = { id: 'src-ws', name: 'Parent' } as never
+const SOURCE = { id: 'src-ws', name: 'Parent', allowPersonalApiKeys: false } as never
 const POLICY = {
   organizationId: null,
   workspaceMode: 'personal',
@@ -210,6 +210,15 @@ describe('createFork storage headroom gate', () => {
     )
   })
 
+  it('preserves the source workspace personal API-key policy in the child', async () => {
+    const result = await createFork(forkParams())
+
+    expect(result.workspace.allowPersonalApiKeys).toBe(false)
+    expect(dbChainMockFns.values).toHaveBeenCalledWith(
+      expect.objectContaining({ allowPersonalApiKeys: false })
+    )
+  })
+
   it('seeds identity mappings for copied FILES by storage key (a later sync must not re-offer them)', async () => {
     mockPlanForkFileCopies.mockResolvedValue({
       keyMap: new Map([['workspace/src-ws/a.png', 'workspace/child/a.png']]),

apps/sim/ee/workspace-forking/lib/create-fork.ts

@@ -170,7 +170,7 @@ export async function createFork(params: CreateForkParams): Promise<CreateForkRe
       organizationId: policy.organizationId,
       workspaceMode: policy.workspaceMode,
       billedAccountUserId: policy.billedAccountUserId,
-      allowPersonalApiKeys: true,
+      allowPersonalApiKeys: source.allowPersonalApiKeys,
       forkedFromWorkspaceId: source.id,
       createdAt: now,
       updatedAt: now,
@@ -418,7 +418,7 @@ export async function createFork(params: CreateForkParams): Promise<CreateForkRe
           organizationId: policy.organizationId,
           workspaceMode: policy.workspaceMode,
           billedAccountUserId: policy.billedAccountUserId,
-          allowPersonalApiKeys: true,
+          allowPersonalApiKeys: source.allowPersonalApiKeys,
           forkedFromWorkspaceId: source.id,
         },
         workflowsCopied,

apps/sim/lib/knowledge/application/connectors.test.ts

@@ -15,6 +15,8 @@ const mocks = vi.hoisted(() => ({
   deleteConnector: vi.fn(),
   syncConnector: vi.fn(),
   resolveBilling: vi.fn(),
+  getCredentialActorContext: vi.fn(),
+  canUseCredential: vi.fn(),
   resolveTokenIdentity: vi.fn(),
   refreshToken: vi.fn(),
   validateConnectorConfig: vi.fn(),
@@ -56,6 +58,8 @@ vi.mock('@/lib/knowledge/orchestration/connectors', () => ({
 }))
 
 vi.mock('@/lib/credentials/access', () => ({
+  getCredentialActorContext: mocks.getCredentialActorContext,
+  canUseCredential: mocks.canUseCredential,
   resolveCredentialTokenIdentity: mocks.resolveTokenIdentity,
 }))
 
@@ -120,6 +124,17 @@ describe('knowledge connector application use cases', () => {
     mocks.resolvePermission.mockResolvedValue('write')
     mocks.resolveKnowledgeBase.mockResolvedValue(crossWorkspaceContext)
     mocks.resolveConnector.mockResolvedValue(connectorContext)
+    mocks.getCredentialActorContext.mockResolvedValue({
+      credential: { id: 'credential-1', workspaceId: 'workspace-a' },
+      member: { role: 'member' },
+      hasWorkspaceAccess: true,
+      canWriteWorkspace: true,
+      isAdmin: false,
+    })
+    mocks.canUseCredential.mockImplementation(
+      (access: { hasWorkspaceAccess: boolean; member: unknown; isAdmin: boolean }) =>
+        access.hasWorkspaceAccess && (Boolean(access.member) || access.isAdmin)
+    )
     mocks.resolveTokenIdentity.mockResolvedValue({ kind: 'oauth', userId: 'credential-owner' })
     mocks.refreshToken.mockResolvedValue('access-token')
     mocks.validateConnectorConfig.mockResolvedValue({ valid: true })
@@ -296,6 +311,7 @@ describe('knowledge connector application use cases', () => {
     expect(mocks.resolvePermission.mock.invocationCallOrder[0]).toBeLessThan(
       mocks.updateConnector.mock.invocationCallOrder[0]
     )
+    expect(mocks.getCredentialActorContext).toHaveBeenCalledWith('credential-1', 'shared-user')
     expect(mocks.resolveTokenIdentity).toHaveBeenCalledWith('credential-1', 'workspace-a')
     expect(mocks.refreshToken).toHaveBeenCalledWith(
       'credential-1',
@@ -305,6 +321,117 @@ describe('knowledge connector application use cases', () => {
     expect(mocks.validateConnectorConfig).toHaveBeenCalledWith('access-token', { space: 'ENG' })
   })
 
+  it('rejects connector creation when the writer cannot use the workspace credential', async () => {
+    const sameWorkspaceContext = {
+      ...connectorContext,
+      workspaceId: 'workspace-a',
+      knowledgeBaseId: 'knowledge-a',
+      knowledgeBase: { id: 'knowledge-a', name: 'Workspace A docs' },
+      connector: { ...connectorContext.connector, knowledgeBaseId: 'knowledge-a' },
+    }
+    mocks.resolveKnowledgeBase.mockResolvedValueOnce(sameWorkspaceContext)
+    mocks.getCredentialActorContext.mockResolvedValueOnce({
+      credential: { id: 'credential-1', workspaceId: 'workspace-a' },
+      member: null,
+      hasWorkspaceAccess: true,
+      canWriteWorkspace: true,
+      isAdmin: false,
+    })
+    mocks.createConnector.mockImplementationOnce(
+      async (input: { resolveAccessToken: (credentialId: string) => Promise<string | null> }) => {
+        const accessToken = await input.resolveAccessToken('credential-1')
+        return accessToken
+          ? { success: true, connector: sameWorkspaceContext.connector }
+          : {
+              success: false,
+              error: 'Credential has no access token. Please reconnect your account.',
+              errorCode: 'validation',
+            }
+      }
+    )
+
+    await expect(
+      createKnowledgeConnector.execute({
+        principal: delegatedPrincipal,
+        input: {
+          knowledgeBaseId: 'knowledge-a',
+          assertedWorkspaceId: 'workspace-a',
+          connectorType: 'confluence',
+          credentialId: 'credential-1',
+          sourceConfig: {},
+          syncIntervalMinutes: 1440,
+          resolveBillingAttribution: mocks.resolveBilling,
+        },
+      })
+    ).rejects.toMatchObject({ code: 'validation' })
+
+    expect(mocks.getCredentialActorContext).toHaveBeenCalledWith('credential-1', 'shared-user')
+    expect(mocks.resolveTokenIdentity).not.toHaveBeenCalled()
+    expect(mocks.refreshToken).not.toHaveBeenCalled()
+  })
+
+  it('rejects source-config revalidation after credential membership is removed', async () => {
+    const sameWorkspaceContext = {
+      ...connectorContext,
+      workspaceId: 'workspace-a',
+      knowledgeBaseId: 'knowledge-a',
+      knowledgeBase: { id: 'knowledge-a', name: 'Workspace A docs' },
+      connector: { ...connectorContext.connector, knowledgeBaseId: 'knowledge-a' },
+    }
+    mocks.resolveConnector.mockResolvedValueOnce(sameWorkspaceContext)
+    mocks.updateConnector.mockResolvedValueOnce({
+      success: true,
+      connector: { ...sameWorkspaceContext.connector, sourceConfig: { space: 'ENG' } },
+    })
+
+    await updateKnowledgeConnector.execute({
+      principal: delegatedPrincipal,
+      input: {
+        connectorId: 'connector-b',
+        assertedWorkspaceId: 'workspace-a',
+        updates: { sourceConfig: { space: 'ENG' } },
+      },
+    })
+
+    const orchestrationInput = mocks.updateConnector.mock.calls[0]?.[0] as {
+      validateSourceConfig?: (
+        connector: {
+          connectorType: string
+          credentialId: string
+          encryptedApiKey: null
+        },
+        sourceConfig: Record<string, unknown>
+      ) => Promise<unknown>
+    }
+    if (!orchestrationInput.validateSourceConfig) {
+      throw new Error('Application command did not provide source-config validation')
+    }
+    mocks.getCredentialActorContext.mockResolvedValueOnce({
+      credential: { id: 'credential-1', workspaceId: 'workspace-a' },
+      member: null,
+      hasWorkspaceAccess: true,
+      canWriteWorkspace: true,
+      isAdmin: false,
+    })
+
+    await expect(
+      orchestrationInput.validateSourceConfig(
+        {
+          connectorType: 'confluence',
+          credentialId: 'credential-1',
+          encryptedApiKey: null,
+        },
+        { space: 'ENG' }
+      )
+    ).resolves.toEqual({
+      message: 'Credential is no longer usable in this workspace. Please reconnect it.',
+      errorCode: 'validation',
+    })
+    expect(mocks.resolveTokenIdentity).not.toHaveBeenCalled()
+    expect(mocks.refreshToken).not.toHaveBeenCalled()
+    expect(mocks.validateConnectorConfig).not.toHaveBeenCalled()
+  })
+
   it.each([
     [
       'create',

apps/sim/lib/knowledge/application/connectors.ts

@@ -6,7 +6,11 @@ import { decryptApiKey } from '@/lib/api-key/crypto'
 import type { BillingAttributionSnapshot } from '@/lib/billing/core/billing-attribution'
 import { OrchestrationError } from '@/lib/core/orchestration/types'
 import { generateRequestId } from '@/lib/core/utils/request'
-import { resolveCredentialTokenIdentity } from '@/lib/credentials/access'
+import {
+  canUseCredential,
+  getCredentialActorContext,
+  resolveCredentialTokenIdentity,
+} from '@/lib/credentials/access'
 import { defineAuthorizedKnowledgeUseCase } from '@/lib/knowledge/application/authorized-knowledge-use-case'
 import { resolveKnowledgeAttributedUserId } from '@/lib/knowledge/application/billing'
 import {
@@ -116,13 +120,29 @@ function requireConnectorWorkspaceId(context: ActiveKnowledgeResourceBaseContext
   return context.workspaceId
 }
 
+async function resolveAuthorizedConnectorCredentialIdentity(input: {
+  credentialId: string
+  workspaceId: string
+  actingUserId: string
+}) {
+  const access = await getCredentialActorContext(input.credentialId, input.actingUserId)
+  if (
+    !access.credential ||
+    access.credential.workspaceId !== input.workspaceId ||
+    !canUseCredential(access)
+  ) {
+    return null
+  }
+  return resolveCredentialTokenIdentity(input.credentialId, input.workspaceId)
+}
+
 async function resolveConnectorCredentialAccessToken(input: {
   credentialId: string
   workspaceId: string
   actingUserId: string
   requestId: string
 }): Promise<string | null> {
-  const identity = await resolveCredentialTokenIdentity(input.credentialId, input.workspaceId)
+  const identity = await resolveAuthorizedConnectorCredentialIdentity(input)
   if (!identity) return null
   return refreshAccessTokenIfNeeded(
     input.credentialId,
@@ -163,10 +183,11 @@ async function validateConnectorSourceConfig(input: {
         errorCode: 'validation',
       }
     }
-    const identity = await resolveCredentialTokenIdentity(
-      input.connector.credentialId,
-      input.workspaceId
-    )
+    const identity = await resolveAuthorizedConnectorCredentialIdentity({
+      credentialId: input.connector.credentialId,
+      workspaceId: input.workspaceId,
+      actingUserId: input.actingUserId,
+    })
     if (!identity) {
       return {
         message: 'Credential is no longer usable in this workspace. Please reconnect it.',