Commit a4d76a6
committed
fix(microsoft-ad): allow $search+$filter combo, escape backslashes, fix pagination UX
Second independent 4-agent re-audit of the final state (post security fix)
surfaced 3 more real issues:
- list_users/list_groups threw an error whenever $search and $filter were
both supplied, claiming Graph doesn't support combining them. It does
(AND semantics, documented) — the check was blocking valid, documented
usage for no reason. Removed it.
- The $search term escaping only handled embedded double quotes, not
backslashes, which Graph's own escaping rule also requires. Fixed the
replace order (backslashes first, then quotes).
- list_group_members's Group ID field was still hard-required in the
block UI for every operation including list_group_members, undermining
the nextLink-only pagination path added earlier (the tool itself no
longer requires it). Dropped list_group_members from the UI-required
list, matching the tool's own conditional requirement — the runtime
"Group ID is required" check still catches a genuinely empty call.1 parent 9e00f2d commit a4d76a6
3 files changed
Lines changed: 2 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
223 | 223 | | |
224 | 224 | | |
225 | 225 | | |
226 | | - | |
227 | 226 | | |
228 | 227 | | |
229 | 228 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
60 | 60 | | |
61 | 61 | | |
62 | 62 | | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | 63 | | |
67 | 64 | | |
68 | | - | |
| 65 | + | |
69 | 66 | | |
70 | 67 | | |
71 | 68 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | 60 | | |
64 | 61 | | |
65 | | - | |
| 62 | + | |
66 | 63 | | |
67 | 64 | | |
68 | 65 | | |
| |||
0 commit comments