fix(canvas): stop the handoff highlight pinning a bystander's toolbar open

Dropping `isWorkflowRunning` from `forceOpen` was not enough: it also read
`usesSelectedVisuals`, which is `isNodeSelected || isExecutionHighlighted`, and
the handoff highlight covers the block feeding the running one. So the upstream
card kept its bar down for the whole run — the wall of open swells this was
supposed to end, one card smaller.

Those are two different questions. `usesSelectedVisuals` still drives the
TREATMENT — the graphite silhouette and `data-node-selected`, so the eye can
follow the baton — while whether the toolbar is pinned open now keys off
selection alone.

The container keeps `isRunning` by itself. Selection was never a pin there, and
its own tests hold it to opening on hover.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Author: icecrasher321

packages/workflow-renderer/src/subflow/subflow-node-view.tsx

@@ -454,7 +454,14 @@ export function SubflowNodeView({
      * unreachable, so those cards could neither retract nor respond. The block
      * that is actually running keeps both.
      */
-    forceOpen: isExecutionHighlighted || isRunning,
+    /*
+     * A container in the handoff into the running block takes the selected
+     * TREATMENT — graphite silhouette, so the eye can follow the baton — but
+     * that is not a reason to pin its toolbar open, which left it down for the
+     * whole run. Selection is deliberately not here either: a selected container
+     * opens on hover like any other, which is what its own tests pin.
+     */
+    forceOpen: isRunning,
     suspendInteraction: isRunning,
     suppressNestedNodeHover: true,
   })

packages/workflow-renderer/src/workflow-block/workflow-block-view-interaction.test.tsx

@@ -137,6 +137,26 @@ describe('WorkflowBlockView action menu', () => {
     expect(actionMenuRoot).not.toHaveAttribute('data-action-menu-ready')
   })
 
+  /**
+   * The handoff source takes the selected treatment so the eye can follow the
+   * baton, but that is not a reason to pin its toolbar open — that left the
+   * upstream card's bar down for the whole run.
+   */
+  it('does not pin the toolbar open for a block merely in the handoff', () => {
+    const host = document.createElement('div')
+    document.body.appendChild(host)
+    const root = createRoot(host)
+    mountedRoots.add(root)
+    mountedHosts.add(host)
+
+    act(() => root.render(createView(false, true, false, true, true)))
+    flushAnimationFrames()
+
+    const actionMenuRoot = host.querySelector<HTMLElement>('.group.relative')
+    expect(actionMenuRoot).toHaveAttribute('data-node-selected')
+    expect(actionMenuRoot).not.toHaveAttribute('data-action-menu-ready')
+  })
+
   it('uses the selected graphite treatment for a block in the active handoff', () => {
     const host = document.createElement('div')
     document.body.appendChild(host)

packages/workflow-renderer/src/workflow-block/workflow-block-view.tsx

@@ -638,6 +638,9 @@ export function WorkflowBlockView({
     sourceBounds.push(nextBounds)
   }, [id, reactFlowStore])
   const isNodeSelected = hasRing && ringStyles.includes('--text-secondary')
+  /* Treatment only — the silhouette and `data-node-selected`. Whether the
+     action menu is pinned open is a separate question, answered by
+     `isNodeSelected` alone below. */
   const usesSelectedVisuals = isNodeSelected || isExecutionHighlighted
   const showActionMenu = Boolean(actionBar)
   const {
@@ -658,7 +661,14 @@ export function WorkflowBlockView({
      * unreachable, so those cards could neither retract nor respond. The block
      * that is actually running keeps both.
      */
-    forceOpen: Boolean(usesSelectedVisuals || isRunning),
+    /*
+     * `isNodeSelected`, not `usesSelectedVisuals`: a block in the handoff into
+     * the running one takes the selected TREATMENT — graphite silhouette, so the
+     * eye can follow the baton — but that is not a reason to pin its toolbar
+     * open. Including it left the upstream card's bar down permanently through a
+     * run, which is the wall-of-open-swells this was supposed to end.
+     */
+    forceOpen: Boolean(isNodeSelected || isRunning),
     maxWidth: ACTION_MENU_MAX_WIDTH_PX,
     suspendInteraction: isRunning,
   })