Skip to content

Commit a2959f5

Browse files
waleedlatif1claude
andcommitted
fix(knowledge): fix connector delete test and use URL-safe searchParams
Use `new URL(request.url).searchParams` instead of `request.nextUrl.searchParams` for compatibility with test mocks. Add missing `connectorType` to test fixture. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent ee5cc5b commit a2959f5

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

apps/sim/app/api/knowledge/[id]/connectors/[connectorId]/route.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,7 @@ describe('Knowledge Connector By ID API Route', () => {
237237
.mockReturnValueOnce(mockDbChain)
238238
.mockResolvedValueOnce([{ id: 'doc-1', fileUrl: '/api/uploads/test.txt' }])
239239
.mockReturnValueOnce(mockDbChain)
240-
mockDbChain.limit.mockResolvedValueOnce([{ id: 'conn-456' }])
240+
mockDbChain.limit.mockResolvedValueOnce([{ id: 'conn-456', connectorType: 'jira' }])
241241
mockDbChain.returning.mockResolvedValueOnce([{ id: 'conn-456' }])
242242

243243
const req = createMockRequest('DELETE')

apps/sim/app/api/knowledge/[id]/connectors/[connectorId]/route.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -292,7 +292,8 @@ export async function DELETE(request: NextRequest, { params }: RouteParams) {
292292
return NextResponse.json({ error: 'Connector not found' }, { status: 404 })
293293
}
294294

295-
const deleteDocuments = request.nextUrl.searchParams.get('deleteDocuments') === 'true'
295+
const { searchParams } = new URL(request.url)
296+
const deleteDocuments = searchParams.get('deleteDocuments') === 'true'
296297

297298
const { deletedDocs, docCount } = await db.transaction(async (tx) => {
298299
await tx.execute(sql`SELECT 1 FROM knowledge_connector WHERE id = ${connectorId} FOR UPDATE`)

0 commit comments

Comments
 (0)