fix(auth): revert lint autofix on hasExternalApiCredentials return type

Also pin SFTP/SSH connections to validated resolved IP to prevent DNS rebinding.

Author: waleedlatif1

apps/sim/app/api/tools/sftp/utils.ts

@@ -104,6 +104,8 @@ export async function createSftpConnection(config: SftpConnectionConfig): Promis
     throw new Error(hostValidation.error)
   }
 
+  const resolvedHost = hostValidation.resolvedIP ?? host.trim()
+
   return new Promise((resolve, reject) => {
     const client = new Client()
     const port = config.port || 22
@@ -117,7 +119,7 @@ export async function createSftpConnection(config: SftpConnectionConfig): Promis
     }
 
     const connectConfig: ConnectConfig = {
-      host: host.trim(),
+      host: resolvedHost,
       port,
       username: config.username,
     }

apps/sim/app/api/tools/ssh/utils.ts

@@ -121,6 +121,8 @@ export async function createSSHConnection(config: SSHConnectionConfig): Promise<
     throw new Error(hostValidation.error)
   }
 
+  const resolvedHost = hostValidation.resolvedIP ?? host.trim()
+
   return new Promise((resolve, reject) => {
     const client = new Client()
     const port = config.port || 22
@@ -134,7 +136,7 @@ export async function createSSHConnection(config: SSHConnectionConfig): Promise<
     }
 
     const connectConfig: ConnectConfig = {
-      host: host.trim(),
+      host: resolvedHost,
       port,
       username: config.username,
     }

apps/sim/lib/auth/hybrid.ts

@@ -25,7 +25,7 @@ const BEARER_PREFIX = 'Bearer '
 export function hasExternalApiCredentials(headers: Headers): boolean {
   if (headers.has(API_KEY_HEADER)) return true
   const auth = headers.get('authorization')
-  return auth?.startsWith(BEARER_PREFIX)
+  return auth !== null && auth.startsWith(BEARER_PREFIX)
 }
 
 export interface AuthResult {