fix(whatsapp): treat 2xx mark-as-read as success unless body says success:false

waleedlatif1 · waleedlatif1 · commit 96caadba967e · 2026-06-28T21:33:51.000-07:00
diff --git a/apps/sim/tools/whatsapp/mark_read.ts b/apps/sim/tools/whatsapp/mark_read.ts
@@ -59,10 +59,13 @@ export const markReadTool: ToolConfig<WhatsAppMarkReadParams, WhatsAppMarkReadRe
       throw new Error(errorMessage)
     }
 
+    // A 2xx response means the mark-as-read succeeded (Graph returns `{"success": true}`).
+    // Treat the HTTP success as authoritative and only report failure if the body
+    // explicitly says otherwise, so an empty or variant 200 body isn't misreported.
     return {
       success: true,
       output: {
-        success: data.success === true,
+        success: data.success !== false,
       },
     }
   },

Original file line number	Diff line number	Diff line change
`@@ -59,10 +59,13 @@ export const markReadTool: ToolConfig<WhatsAppMarkReadParams, WhatsAppMarkReadRe`
`59`	`59`	`throw new Error(errorMessage)`
`60`	`60`	`}`
`61`	`61`
	`62`	+ // A 2xx response means the mark-as-read succeeded (Graph returns `{"success": true}`).
	`63`	`+ // Treat the HTTP success as authoritative and only report failure if the body`
	`64`	`+ // explicitly says otherwise, so an empty or variant 200 body isn't misreported.`
`62`	`65`	`return {`
`63`	`66`	`success: true,`
`64`	`67`	`output: {`
`65`		`- success: data.success === true,`
	`68`	`+ success: data.success !== false,`
`66`	`69`	`},`
`67`	`70`	`}`
`68`	`71`	`},`