Skip to content

Commit 93ff06b

Browse files
committed
fix(emcn): drop the brand highlight from popover menus
Context menus opted into a palette of their own — `variant='secondary'` for a brand-blue row highlight and `colorScheme='inverted'` for a dark card — so the canvas, block, toolbar, terminal, sidebar, and preview menus looked nothing like the menus everywhere else in the product. Removes both overrides so they inherit the same surface, border, and `--surface-active` highlight the terminal's overflow menu already uses, and drops the brand state from the Popover itself along with the `variant` prop that only ever selected it. One fewer way to style a menu.
1 parent b6c007e commit 93ff06b

11 files changed

Lines changed: 20 additions & 98 deletions

File tree

apps/sim/app/playground/page.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -868,10 +868,10 @@ export default function PlaygroundPage() {
868868
</PopoverContent>
869869
</Popover>
870870
</VariantRow>
871-
<VariantRow label='secondary variant'>
872-
<Popover variant='secondary'>
871+
<VariantRow label='inverted color scheme'>
872+
<Popover colorScheme='inverted'>
873873
<PopoverTrigger asChild>
874-
<Button variant='secondary'>Secondary Popover</Button>
874+
<Button variant='secondary'>Inverted Popover</Button>
875875
</PopoverTrigger>
876876
<PopoverContent>
877877
<PopoverItem>Item 1</PopoverItem>

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/block-menu/block-menu.tsx

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -130,13 +130,7 @@ export function BlockMenu({
130130
}
131131

132132
return (
133-
<Popover
134-
open={isOpen}
135-
onOpenChange={(open) => !open && onClose()}
136-
variant='secondary'
137-
size='sm'
138-
colorScheme='inverted'
139-
>
133+
<Popover open={isOpen} onOpenChange={(open) => !open && onClose()} size='sm'>
140134
<PopoverAnchor
141135
style={{
142136
position: 'fixed',

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/canvas-menu/canvas-menu.tsx

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -70,13 +70,7 @@ export function CanvasMenu({
7070
hasBlocks = false,
7171
}: CanvasMenuProps) {
7272
return (
73-
<Popover
74-
open={isOpen}
75-
onOpenChange={(open) => !open && onClose()}
76-
variant='secondary'
77-
size='sm'
78-
colorScheme='inverted'
79-
>
73+
<Popover open={isOpen} onOpenChange={(open) => !open && onClose()} size='sm'>
8074
<PopoverAnchor
8175
style={{
8276
position: 'fixed',

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/chat/chat.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -947,7 +947,7 @@ export function Chat() {
947947

948948
<div className='flex flex-shrink-0 items-center gap-2'>
949949
{/* More menu with actions */}
950-
<Popover variant='default' size='sm' open={moreMenuOpen} onOpenChange={setMoreMenuOpen}>
950+
<Popover size='sm' open={moreMenuOpen} onOpenChange={setMoreMenuOpen}>
951951
<PopoverTrigger asChild>
952952
<Button
953953
variant='ghost'

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/toolbar/components/toolbar-item-context-menu/toolbar-item-context-menu.tsx

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -47,13 +47,7 @@ export function ToolbarItemContextMenu({
4747
showViewDocumentation = false,
4848
}: ToolbarItemContextMenuProps) {
4949
return (
50-
<Popover
51-
open={isOpen}
52-
onOpenChange={(open) => !open && onClose()}
53-
variant='secondary'
54-
size='sm'
55-
colorScheme='inverted'
56-
>
50+
<Popover open={isOpen} onOpenChange={(open) => !open && onClose()} size='sm'>
5751
<PopoverAnchor
5852
style={{
5953
position: 'fixed',

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/terminal/components/log-row-context-menu/log-row-context-menu.tsx

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -47,13 +47,7 @@ export const LogRowContextMenu = memo(function LogRowContextMenu({
4747
const isStatusFiltered = entry ? filters.statuses.has(entryStatus) : false
4848

4949
return (
50-
<Popover
51-
open={isOpen}
52-
onOpenChange={(open) => !open && onClose()}
53-
variant='secondary'
54-
size='sm'
55-
colorScheme='inverted'
56-
>
50+
<Popover open={isOpen} onOpenChange={(open) => !open && onClose()} size='sm'>
5751
<PopoverAnchor
5852
style={{
5953
position: 'fixed',

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/terminal/components/output-panel/components/output-context-menu.tsx

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -44,13 +44,7 @@ export const OutputContextMenu = memo(function OutputContextMenu({
4444
hasSelection,
4545
}: OutputContextMenuProps) {
4646
return (
47-
<Popover
48-
open={isOpen}
49-
onOpenChange={(open) => !open && onClose()}
50-
variant='secondary'
51-
size='sm'
52-
colorScheme='inverted'
53-
>
47+
<Popover open={isOpen} onOpenChange={(open) => !open && onClose()} size='sm'>
5448
<PopoverAnchor
5549
style={{
5650
position: 'fixed',

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/workflow-controls/workflow-controls.tsx

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -93,12 +93,7 @@ export const WorkflowControls = memo(function WorkflowControls() {
9393
onContextMenu={handleContextMenu}
9494
>
9595
{/* Canvas Mode Selector */}
96-
<Popover
97-
open={isCanvasModeOpen}
98-
onOpenChange={setIsCanvasModeOpen}
99-
variant='secondary'
100-
size='sm'
101-
>
96+
<Popover open={isCanvasModeOpen} onOpenChange={setIsCanvasModeOpen} size='sm'>
10297
<Tooltip.Root>
10398
<PopoverTrigger asChild>
10499
<div className='flex cursor-pointer items-center gap-1'>
@@ -197,9 +192,7 @@ export const WorkflowControls = memo(function WorkflowControls() {
197192
<Popover
198193
open={contextMenu !== null}
199194
onOpenChange={(open) => !open && setContextMenu(null)}
200-
variant='secondary'
201195
size='sm'
202-
colorScheme='inverted'
203196
>
204197
<PopoverAnchor
205198
style={{

apps/sim/app/workspace/[workspaceId]/w/components/preview/components/preview-context-menu/preview-context-menu.tsx

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -36,13 +36,7 @@ export function PreviewContextMenu({
3636
if (typeof document === 'undefined') return null
3737

3838
return createPortal(
39-
<Popover
40-
open={isOpen}
41-
onOpenChange={(open) => !open && onClose()}
42-
variant='secondary'
43-
size='sm'
44-
colorScheme='inverted'
45-
>
39+
<Popover open={isOpen} onOpenChange={(open) => !open && onClose()} size='sm'>
4640
<PopoverAnchor
4741
style={{
4842
position: 'fixed',

apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/workflow-list/components/empty-area-context-menu/empty-area-context-menu.tsx

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -52,13 +52,7 @@ export function EmptyAreaContextMenu({
5252
disableCreateFolder = false,
5353
}: EmptyAreaContextMenuProps) {
5454
return (
55-
<Popover
56-
open={isOpen}
57-
onOpenChange={(open) => !open && onClose()}
58-
variant='secondary'
59-
size='sm'
60-
colorScheme='inverted'
61-
>
55+
<Popover open={isOpen} onOpenChange={(open) => !open && onClose()} size='sm'>
6256
<PopoverAnchor
6357
style={{
6458
position: 'fixed',

0 commit comments

Comments
 (0)