fix(search): address PR feedback — drop files/jobs, add onSelect to memo

Author: waleedlatif1

apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/search-modal/_components/command-items.tsx

@@ -185,5 +185,9 @@ export const MemoizedIconItem = memo(
       </Command.Item>
     )
   },
-  (prev, next) => prev.value === next.value && prev.name === next.name && prev.icon === next.icon
+  (prev, next) =>
+    prev.value === next.value &&
+    prev.name === next.name &&
+    prev.icon === next.icon &&
+    prev.onSelect === next.onSelect
 )

apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/search-modal/_components/search-groups.tsx

@@ -3,7 +3,7 @@
 import type { ComponentType } from 'react'
 import { memo } from 'react'
 import { Command } from 'cmdk'
-import { Calendar, Database, File, Table } from '@/components/emcn/icons'
+import { Database, Table } from '@/components/emcn/icons'
 import type {
   SearchBlockItem,
   SearchDocItem,
@@ -244,9 +244,7 @@ export const PagesGroup = memo(function PagesGroup({
 })
 
 export const TablesGroup = createIconGroup('Tables', 'table', Table)
-export const FilesGroup = createIconGroup('Files', 'file', File)
 export const KnowledgeBasesGroup = createIconGroup('Knowledge Bases', 'knowledge-base', Database)
-export const JobsGroup = createIconGroup('Jobs', 'job', Calendar)
 
 function createIconGroup(
   heading: string,

apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/search-modal/search-modal.tsx

@@ -21,8 +21,6 @@ import type {
 import {
   BlocksGroup,
   DocsGroup,
-  FilesGroup,
-  JobsGroup,
   KnowledgeBasesGroup,
   PagesGroup,
   TablesGroup,
@@ -45,9 +43,7 @@ export function SearchModal({
   workspaces = [],
   tasks = [],
   tables = [],
-  files = [],
   knowledgeBases = [],
-  jobs = [],
   isOnWorkflowPage = false,
 }: SearchModalProps) {
   const params = useParams()
@@ -296,19 +292,11 @@ export function SearchModal({
     () => filterAndSort(tables, (t) => `${t.name} table-${t.id}`, deferredSearch),
     [tables, deferredSearch]
   )
-  const filteredFiles = useMemo(
-    () => filterAndSort(files, (f) => `${f.name} file-${f.id}`, deferredSearch),
-    [files, deferredSearch]
-  )
   const filteredKnowledgeBases = useMemo(
     () =>
       filterAndSort(knowledgeBases, (kb) => `${kb.name} knowledge-base-${kb.id}`, deferredSearch),
     [knowledgeBases, deferredSearch]
   )
-  const filteredJobs = useMemo(
-    () => filterAndSort(jobs, (j) => `${j.name} job-${j.id}`, deferredSearch),
-    [jobs, deferredSearch]
-  )
 
   const filteredWorkflows = useMemo(
     () => filterAndSort(workflows, (w) => `${w.name} workflow-${w.id}`, deferredSearch),
@@ -373,9 +361,7 @@ export function SearchModal({
             <WorkflowsGroup items={filteredWorkflows} onSelect={handleWorkflowSelect} />
             <TasksGroup items={filteredTasks} onSelect={handleTaskSelect} />
             <TablesGroup items={filteredTables} onSelect={handleTaskSelect} />
-            <FilesGroup items={filteredFiles} onSelect={handleTaskSelect} />
             <KnowledgeBasesGroup items={filteredKnowledgeBases} onSelect={handleTaskSelect} />
-            <JobsGroup items={filteredJobs} onSelect={handleTaskSelect} />
             <ToolOpsGroup items={filteredToolOps} onSelect={handleToolOperationSelect} />
             <WorkspacesGroup items={filteredWorkspaces} onSelect={handleWorkspaceSelect} />
             <DocsGroup items={filteredDocs} onSelect={handleDocSelect} />

apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/search-modal/utils.ts

@@ -38,9 +38,7 @@ export interface SearchModalProps {
   workspaces?: WorkspaceItem[]
   tasks?: TaskItem[]
   tables?: TaskItem[]
-  files?: TaskItem[]
   knowledgeBases?: TaskItem[]
-  jobs?: TaskItem[]
   isOnWorkflowPage?: boolean
 }
 

apps/sim/app/workspace/[workspaceId]/w/components/sidebar/sidebar.tsx

@@ -78,7 +78,6 @@ import {
 import { getBrandConfig } from '@/ee/whitelabeling'
 import { useFolders } from '@/hooks/queries/folders'
 import { useKnowledgeBasesQuery } from '@/hooks/queries/kb/knowledge'
-import { useWorkspaceSchedules } from '@/hooks/queries/schedules'
 import { useTablesList } from '@/hooks/queries/tables'
 import {
   useDeleteTask,
@@ -88,7 +87,6 @@ import {
   useRenameTask,
   useTasks,
 } from '@/hooks/queries/tasks'
-import { useWorkspaceFiles } from '@/hooks/queries/workspace-files'
 import { usePermissionConfig } from '@/hooks/use-permission-config'
 import { useSettingsNavigation } from '@/hooks/use-settings-navigation'
 import { useTaskEvents } from '@/hooks/use-task-events'
@@ -750,9 +748,7 @@ export const Sidebar = memo(function Sidebar() {
   )
 
   const { data: fetchedTables = [] } = useTablesList(workspaceId)
-  const { data: fetchedFiles = [] } = useWorkspaceFiles(workspaceId)
   const { data: fetchedKnowledgeBases = [] } = useKnowledgeBasesQuery(workspaceId)
-  const { data: fetchedSchedules = [] } = useWorkspaceSchedules(workspaceId)
 
   const searchModalTables = useMemo(
     () =>
@@ -766,18 +762,6 @@ export const Sidebar = memo(function Sidebar() {
     [fetchedTables, workspaceId, permissionConfig.hideTablesTab]
   )
 
-  const searchModalFiles = useMemo(
-    () =>
-      permissionConfig.hideFilesTab
-        ? []
-        : fetchedFiles.map((f) => ({
-            id: f.id,
-            name: f.name,
-            href: `/workspace/${workspaceId}/files`,
-          })),
-    [fetchedFiles, workspaceId, permissionConfig.hideFilesTab]
-  )
-
   const searchModalKnowledgeBases = useMemo(
     () =>
       permissionConfig.hideKnowledgeBaseTab
@@ -790,18 +774,6 @@ export const Sidebar = memo(function Sidebar() {
     [fetchedKnowledgeBases, workspaceId, permissionConfig.hideKnowledgeBaseTab]
   )
 
-  const searchModalJobs = useMemo(
-    () =>
-      fetchedSchedules
-        .filter((s) => s.sourceType === 'job')
-        .map((s) => ({
-          id: s.id,
-          name: s.jobTitle || 'Untitled Job',
-          href: `/workspace/${workspaceId}/scheduled-tasks`,
-        })),
-    [fetchedSchedules, workspaceId]
-  )
-
   const taskIds = useMemo(() => tasks.map((t) => t.id).filter((id) => id !== 'new'), [tasks])
 
   const { selectedTasks, handleTaskClick } = useTaskSelection({ taskIds })
@@ -1729,9 +1701,7 @@ export const Sidebar = memo(function Sidebar() {
         workspaces={searchModalWorkspaces}
         tasks={tasks}
         tables={searchModalTables}
-        files={searchModalFiles}
         knowledgeBases={searchModalKnowledgeBases}
-        jobs={searchModalJobs}
         isOnWorkflowPage={!!workflowId}
       />