Skip to content

Commit 86cc363

Browse files
committed
fix(dub): stop trackConversion from resetting existing links on update
- only send trackConversion true or omit it, matching linkRewrite/linkArchived's partial-PATCH-safe pattern, so a routine update_link no longer silently disables conversion tracking on an existing link - include trackConversion in the cross-operation reset block so it can't leak a stale value into non-mutation operations either
1 parent a742bdd commit 86cc363

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

apps/sim/blocks/blocks/dub.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -962,6 +962,7 @@ export const DubBlock: BlockConfig<DubResponse> = {
962962
result.tagIds = undefined
963963
result.tenantId = undefined
964964
result.folderId = undefined
965+
result.trackConversion = undefined
965966
}
966967
if (params.operation !== 'create_link' && params.operation !== 'upsert_link') {
967968
result.url = undefined
@@ -985,7 +986,10 @@ export const DubBlock: BlockConfig<DubResponse> = {
985986
if (params.linkArchived === 'true') result.archived = true
986987
if (params.tenantId) result.tenantId = params.tenantId
987988
if (params.folderId) result.folderId = params.folderId
988-
result.trackConversion = params.trackConversion === 'true'
989+
// Only ever send `true` or omit — an explicit `false` on update_link would
990+
// silently disable conversion tracking on links that already had it enabled,
991+
// since Dub's update is a partial PATCH (matches linkRewrite/linkArchived).
992+
result.trackConversion = params.trackConversion === 'true' ? true : undefined
989993
}
990994
if (params.operation === 'get_link') {
991995
if (params.getLinkExternalId) result.externalId = params.getLinkExternalId

0 commit comments

Comments
 (0)