fix(uploads): not-ready 409 for uptimerobot, real MIME for non-doc, xlsx tests

Address review findings:
- uptimerobot create-psp/update-psp now map DocCompileUserError to the shared
  409 (Greptile + Cursor flagged the gap alongside slack/teams).
- downloadServableFileFromStorage returns the extension-derived MIME
  (getMimeTypeFromExtension) for non-doc files instead of an empty string when
  userFile.type is unset.
- Add resolveServableDocBytes tests for the three xlsx branches (binary ZIP
  passthrough, not-ready throw under E2B+beta, no-workspaceId raw passthrough).

Author: waleedlatif1

apps/sim/app/api/tools/uptimerobot/create-psp/route.ts

@@ -6,6 +6,7 @@ import { parseRequest } from '@/lib/api/server'
 import { checkInternalAuth } from '@/lib/auth/hybrid'
 import { generateRequestId } from '@/lib/core/utils/request'
 import { withRouteHandler } from '@/lib/core/utils/with-route-handler'
+import { docNotReadyResponse } from '@/lib/uploads/utils/servable-file-response'
 import { forwardPspRequest } from '@/app/api/tools/uptimerobot/server-utils'
 
 export const dynamic = 'force-dynamic'
@@ -39,6 +40,8 @@ export const POST = withRouteHandler(async (request: NextRequest) => {
       logger,
     })
   } catch (error) {
+    const notReady = docNotReadyResponse(error)
+    if (notReady) return notReady
     logger.error(`[${requestId}] Unexpected error creating status page:`, error)
     return NextResponse.json(
       { success: false, error: getErrorMessage(error, 'Unknown error') },

apps/sim/app/api/tools/uptimerobot/update-psp/route.ts

@@ -6,6 +6,7 @@ import { parseRequest } from '@/lib/api/server'
 import { checkInternalAuth } from '@/lib/auth/hybrid'
 import { generateRequestId } from '@/lib/core/utils/request'
 import { withRouteHandler } from '@/lib/core/utils/with-route-handler'
+import { docNotReadyResponse } from '@/lib/uploads/utils/servable-file-response'
 import { forwardPspRequest } from '@/app/api/tools/uptimerobot/server-utils'
 
 export const dynamic = 'force-dynamic'
@@ -39,6 +40,8 @@ export const POST = withRouteHandler(async (request: NextRequest) => {
       logger,
     })
   } catch (error) {
+    const notReady = docNotReadyResponse(error)
+    if (notReady) return notReady
     logger.error(`[${requestId}] Unexpected error updating status page:`, error)
     return NextResponse.json(
       { success: false, error: getErrorMessage(error, 'Unknown error') },

apps/sim/lib/copilot/tools/server/files/doc-servable.test.ts

@@ -3,8 +3,9 @@
  */
 import { beforeEach, describe, expect, it, vi } from 'vitest'
 
-const { e2bFlag, mockLoadCompiledDoc, mockRunSandboxTask } = vi.hoisted(() => ({
+const { e2bFlag, betaFlag, mockLoadCompiledDoc, mockRunSandboxTask } = vi.hoisted(() => ({
   e2bFlag: { value: true },
+  betaFlag: { value: false },
   mockLoadCompiledDoc: vi.fn(),
   mockRunSandboxTask: vi.fn(),
 }))
@@ -28,7 +29,7 @@ vi.mock('./doc-compiled-store', () => ({
   storeCompiledDoc: vi.fn(),
 }))
 vi.mock('@/lib/core/config/feature-flags', () => ({
-  isFeatureEnabled: vi.fn().mockResolvedValue(false),
+  isFeatureEnabled: vi.fn(async () => betaFlag.value),
 }))
 vi.mock('@/lib/core/config/env-flags', () => ({
   get isE2BDocEnabled() {
@@ -49,11 +50,14 @@ import { DocCompileUserError, resolveServableDocBytes } from './doc-compile'
 const WORKSPACE_ID = '550e8400-e29b-41d4-a716-446655440000'
 const PDF_MAGIC = Buffer.from('%PDF-1.7\n...binary...')
 const PDF_SOURCE = Buffer.from('from reportlab.pdfgen import canvas\n# generates a PDF', 'utf-8')
+const ZIP_MAGIC = Buffer.from([0x50, 0x4b, 0x03, 0x04, 0x00, 0x01])
+const XLSX_SOURCE = Buffer.from('from openpyxl import Workbook\n# generates an xlsx', 'utf-8')
 
 describe('resolveServableDocBytes', () => {
   beforeEach(() => {
     vi.clearAllMocks()
     e2bFlag.value = true
+    betaFlag.value = false
   })
 
   it('swaps generated-doc source for the compiled artifact + binary content type', async () => {
@@ -135,4 +139,45 @@ describe('resolveServableDocBytes', () => {
     expect(result.contentType).toBe('text/plain')
     expect(mockLoadCompiledDoc).not.toHaveBeenCalled()
   })
+
+  it('passes through a real binary XLSX (ZIP magic) without an artifact lookup', async () => {
+    const result = await resolveServableDocBytes({
+      rawBuffer: ZIP_MAGIC,
+      fileName: 'sheet.xlsx',
+      workspaceId: WORKSPACE_ID,
+    })
+
+    expect(result.buffer).toBe(ZIP_MAGIC)
+    expect(mockLoadCompiledDoc).not.toHaveBeenCalled()
+  })
+
+  it('throws when a generated XLSX artifact is not ready (E2B + mothership-beta enabled)', async () => {
+    mockLoadCompiledDoc.mockResolvedValue(null)
+    e2bFlag.value = true
+    betaFlag.value = true
+
+    await expect(
+      resolveServableDocBytes({
+        rawBuffer: XLSX_SOURCE,
+        fileName: 'sheet.xlsx',
+        workspaceId: WORKSPACE_ID,
+      })
+    ).rejects.toBeInstanceOf(DocCompileUserError)
+
+    expect(mockRunSandboxTask).not.toHaveBeenCalled()
+  })
+
+  it('returns raw XLSX source when there is no workspaceId (xlsx has no isolated-vm path)', async () => {
+    betaFlag.value = true
+
+    const result = await resolveServableDocBytes({
+      rawBuffer: XLSX_SOURCE,
+      fileName: 'sheet.xlsx',
+      workspaceId: undefined,
+    })
+
+    expect(result.buffer).toBe(XLSX_SOURCE)
+    expect(mockLoadCompiledDoc).not.toHaveBeenCalled()
+    expect(mockRunSandboxTask).not.toHaveBeenCalled()
+  })
 })

apps/sim/lib/uploads/utils/file-utils.server.ts

@@ -18,6 +18,7 @@ import { isExecutionFile } from '@/lib/uploads/contexts/execution/utils'
 import {
   extractStorageKey,
   getFileExtension,
+  getMimeTypeFromExtension,
   inferContextFromKey,
   isInternalFileUrl,
   processSingleFileToUserFile,
@@ -342,7 +343,7 @@ export async function downloadServableFileFromStorage(
   // the authority on what actually gets swapped.
   const ext = getFileExtension(userFile.name)
   if (ext !== 'pdf' && ext !== 'docx' && ext !== 'pptx' && ext !== 'xlsx') {
-    return { buffer, contentType: userFile.type || '' }
+    return { buffer, contentType: userFile.type || getMimeTypeFromExtension(ext) }
   }
 
   const { parseWorkspaceFileKey } = await import(