improvement(slack-trigger): reorder app type, gate account to sim mode, add channel-id input

Author: TheodoreSpeaks

apps/sim/app/api/webhooks/slack/route.ts

@@ -145,8 +145,13 @@ async function handleSlackAppWebhook(request: NextRequest): Promise<NextResponse
     }
 
     // Channel filter applies only to channel-scoped events, never to DMs.
+    // Channels can come from the picker (channelFilter) or manual IDs
+    // (manualChannelFilter) — the basic/advanced sides of one canonical field.
     if (eventKey && SLACK_CHANNEL_SCOPED_EVENTS.has(eventKey)) {
-      const selectedChannels = normalizeSelection(providerConfig.channelFilter)
+      const selectedChannels = [
+        ...normalizeSelection(providerConfig.channelFilter),
+        ...normalizeSelection(providerConfig.manualChannelFilter),
+      ]
       if (
         selectedChannels.length > 0 &&
         (!eventChannel || !selectedChannels.includes(eventChannel))

apps/sim/triggers/slack/oauth.ts

@@ -31,6 +31,18 @@ export const slackOAuthTrigger: TriggerConfig = {
       required: true,
       mode: 'trigger',
     },
+    {
+      id: 'appType',
+      title: 'App Type',
+      type: 'dropdown',
+      options: [
+        { label: 'Sim', id: 'sim' },
+        { label: 'Custom', id: 'custom' },
+      ],
+      value: () => 'sim',
+      description: 'Use the official Sim Slack app, or your own custom Slack app.',
+      mode: 'trigger',
+    },
     {
       id: 'triggerCredentials',
       title: 'Slack Account',
@@ -39,8 +51,9 @@ export const slackOAuthTrigger: TriggerConfig = {
       serviceId: 'slack',
       requiredScopes: getScopesForService('slack'),
       placeholder: 'Select Slack account',
-      required: true,
+      required: { field: 'appType', value: 'sim' },
       mode: 'trigger',
+      condition: { field: 'appType', value: 'sim' },
     },
     {
       id: 'channelFilter',
@@ -52,22 +65,20 @@ export const slackOAuthTrigger: TriggerConfig = {
       selectorKey: 'slack.channels',
       placeholder: 'Any channel the bot is in',
       description:
-        'Restrict channel, mention, and reaction events to specific channels. Leave empty to trigger on any channel the Sim bot has been added to. Does not apply to direct messages.',
+        'Restrict channel, mention, and reaction events to specific channels. Leave empty to trigger on any channel the bot has been added to. Does not apply to direct messages.',
       dependsOn: ['triggerCredentials'],
       required: false,
       mode: 'trigger',
     },
     {
-      id: 'appType',
-      title: 'App Type',
-      type: 'dropdown',
-      options: [
-        { label: 'Sim', id: 'sim' },
-        { label: 'Custom', id: 'custom' },
-      ],
-      value: () => 'sim',
-      description: 'Use the official Sim Slack app, or your own custom Slack app.',
-      mode: 'trigger',
+      id: 'manualChannelFilter',
+      title: 'Channel IDs',
+      type: 'short-input',
+      canonicalParamId: 'channelFilter',
+      placeholder: 'C0123456789, C0987654321',
+      description: 'Comma-separated channel IDs to restrict to. Set IDs directly here.',
+      required: false,
+      mode: 'trigger-advanced',
     },
     {
       id: 'webhookUrlDisplay',

packages/db/migrations/0253_fearless_gateway.sql

@@ -1,3 +1,5 @@
 ALTER TABLE "webhook" ALTER COLUMN "path" DROP NOT NULL;--> statement-breakpoint
 ALTER TABLE "webhook" ADD COLUMN "routing_key" text;--> statement-breakpoint
-CREATE INDEX "webhook_routing_key_active_idx" ON "webhook" USING btree ("routing_key","provider") WHERE "webhook"."archived_at" IS NULL AND "webhook"."routing_key" IS NOT NULL;
+COMMIT;--> statement-breakpoint
+SET lock_timeout = 0;--> statement-breakpoint
+CREATE INDEX CONCURRENTLY IF NOT EXISTS "webhook_routing_key_active_idx" ON "webhook" USING btree ("routing_key","provider") WHERE "webhook"."archived_at" IS NULL AND "webhook"."routing_key" IS NOT NULL;

scripts/check-api-validation-contracts.ts

@@ -9,7 +9,7 @@ const QUERY_HOOKS_DIR = path.join(ROOT, 'apps/sim/hooks/queries')
 const SELECTOR_HOOKS_DIR = path.join(ROOT, 'apps/sim/hooks/selectors')
 
 const BASELINE = {
-  totalRoutes: 873,
+  totalRoutes: 874,
   zodRoutes: 873,
   nonZodRoutes: 0,
 } as const
@@ -70,6 +70,10 @@ const INDIRECT_ZOD_ROUTES = new Set([
   'apps/sim/app/api/knowledge/connectors/sync/route.ts',
   'apps/sim/app/api/webhooks/outbox/process/route.ts',
   'apps/sim/app/api/webhooks/cleanup/idempotency/route.ts',
+  // Shared Slack app event ingest. The body is an opaque, HMAC-verified Slack
+  // event envelope (varies per event type) read via parseWebhookBody; there is
+  // no client contract to bind — authenticity is enforced by signature.
+  'apps/sim/app/api/webhooks/slack/route.ts',
   'apps/sim/app/api/resume/poll/route.ts',
   // MCP routes that take only auth context (no client-supplied params/query/body).
   'apps/sim/app/api/mcp/discover/route.ts',