test(desktop): a throwing notifier still claims, and sign-out reaches a closed tab's tmux run

Author: waleedlatif1

apps/desktop/src/main/desktop-executor/executor.test.ts

@@ -671,12 +671,14 @@ describe('registration', () => {
     expect(journal.entries.size).toBe(0)
   })
 
-  it('settles an inbox read whose notifier throws instead of rejecting', async () => {
+  it('still claims the calls of an inbox read whose notifier throws', async () => {
     const sim = new FakeSim()
+    const runner = new FakeRunner()
+    runner.immediate = DONE
     const executor = new DesktopExecutor({
       client: sim.client,
       journal: new MemoryJournal(),
-      runner: new FakeRunner(),
+      runner,
       leaseRenewMs: 60_000,
       retryBaseMs: 5,
       onUnregistered: () => {},
@@ -685,7 +687,10 @@ describe('registration', () => {
       },
     })
 
+    sim.inbox = [callItem('call-1', 'chat-a')]
+
     await expect(executor.reconcile()).resolves.toBeUndefined()
+    await vi.waitFor(() => expect(runner.started).toEqual(['call-1']))
   })
 
   it('raises no approval from an inbox read that Sim answers after sign-out', async () => {

apps/desktop/src/main/terminal/service.test.ts

@@ -638,4 +638,26 @@ describe('agent commands in tmux', () => {
       tmuxFake.gone.clear()
     }
   })
+
+  it('still stops at sign-out a run whose Sim terminal was closed', async () => {
+    tmuxFake.on = true
+    tmuxFake.statusPaths.clear()
+    tmuxFake.stopped.length = 0
+    try {
+      const terminal = new TerminalService({ loadCwd: () => '/tmp' })
+      const { activeTerminalId } = terminal.start({ cols: 80, rows: 24 })
+      const first = await terminal.executeTool('call-orphan', 'run', {
+        command: 'sleep 600',
+        waitSeconds: 1,
+      })
+      expect(first).toMatchObject({ ok: true, result: { status: 'running' } })
+      terminal.closeTerminal(activeTerminalId as string)
+
+      await terminal.stopAgentCommands()
+
+      expect(tmuxFake.stopped).toEqual([[...tmuxFake.statusPaths.keys()][0]])
+    } finally {
+      tmuxFake.on = false
+    }
+  })
 })