fix(linear): coerce first param to number, remove duplicate conditions, add null guard

waleedlatif1 · waleedlatif1 · commit 784fe7ec543f · 2026-02-05T18:33:49.000-08:00
diff --git a/apps/sim/blocks/blocks/linear.ts b/apps/sim/blocks/blocks/linear.ts
@@ -829,8 +829,6 @@ Return ONLY the date string in YYYY-MM-DD format - no explanations, no quotes, n
           'linear_list_customer_tiers',
           'linear_list_customers',
           'linear_list_customer_requests',
-          'linear_list_customer_statuses',
-          'linear_list_customer_tiers',
           'linear_list_project_labels',
           'linear_list_project_milestones',
           'linear_list_project_statuses',
diff --git a/apps/sim/tools/linear/list_customer_requests.ts b/apps/sim/tools/linear/list_customer_requests.ts
@@ -88,7 +88,7 @@ export const linearListCustomerRequestsTool: ToolConfig<
         }
       `,
       variables: {
-        first: params.first || 50,
+        first: params.first ? Number(params.first) : 50,
         after: params.after,
         includeArchived: params.includeArchived || false,
       },
diff --git a/apps/sim/tools/linear/list_customer_statuses.ts b/apps/sim/tools/linear/list_customer_statuses.ts
@@ -69,7 +69,7 @@ export const linearListCustomerStatusesTool: ToolConfig<
         }
       `,
       variables: {
-        first: params.first || 50,
+        first: params.first ? Number(params.first) : 50,
         after: params.after,
       },
     }),
diff --git a/apps/sim/tools/linear/list_customer_tiers.ts b/apps/sim/tools/linear/list_customer_tiers.ts
@@ -68,7 +68,7 @@ export const linearListCustomerTiersTool: ToolConfig<
         }
       `,
       variables: {
-        first: params.first || 50,
+        first: params.first ? Number(params.first) : 50,
         after: params.after,
       },
     }),
diff --git a/apps/sim/tools/linear/list_customers.ts b/apps/sim/tools/linear/list_customers.ts
@@ -75,7 +75,7 @@ export const linearListCustomersTool: ToolConfig<
         }
       `,
       variables: {
-        first: params.first || 50,
+        first: params.first ? Number(params.first) : 50,
         after: params.after,
         includeArchived: params.includeArchived || false,
       },
diff --git a/apps/sim/tools/linear/list_project_labels.ts b/apps/sim/tools/linear/list_project_labels.ts
@@ -81,7 +81,7 @@ export const linearListProjectLabelsTool: ToolConfig<
           `,
           variables: {
             id: params.projectId.trim(),
-            first: params.first || 50,
+            first: params.first ? Number(params.first) : 50,
             after: params.after,
           },
         }
@@ -109,7 +109,7 @@ export const linearListProjectLabelsTool: ToolConfig<
           }
         `,
         variables: {
-          first: params.first || 50,
+          first: params.first ? Number(params.first) : 50,
           after: params.after,
         },
       }
diff --git a/apps/sim/tools/linear/list_project_milestones.ts b/apps/sim/tools/linear/list_project_milestones.ts
@@ -81,7 +81,7 @@ export const linearListProjectMilestonesTool: ToolConfig<
       `,
       variables: {
         id: params.projectId,
-        first: params.first || 50,
+        first: params.first ? Number(params.first) : 50,
         after: params.after,
       },
     }),
diff --git a/apps/sim/tools/linear/list_project_statuses.ts b/apps/sim/tools/linear/list_project_statuses.ts
@@ -70,7 +70,7 @@ export const linearListProjectStatusesTool: ToolConfig<
         }
       `,
       variables: {
-        first: params.first || 50,
+        first: params.first ? Number(params.first) : 50,
         after: params.after,
       },
     }),
diff --git a/apps/sim/tools/linear/list_projects.ts b/apps/sim/tools/linear/list_projects.ts
@@ -93,7 +93,7 @@ export const linearListProjectsTool: ToolConfig<
           }
         `,
         variables: {
-          first: params.first || 50,
+          first: params.first ? Number(params.first) : 50,
           after: params.after,
           includeArchived: params.includeArchived || false,
         },
diff --git a/apps/sim/tools/linear/search_issues.ts b/apps/sim/tools/linear/search_issues.ts
@@ -117,7 +117,7 @@ export const linearSearchIssuesTool: ToolConfig<
         variables: {
           term: params.query,
           filter: Object.keys(filter).length > 0 ? filter : undefined,
-          first: params.first || 50,
+          first: params.first ? Number(params.first) : 50,
           after: params.after,
           includeArchived: params.includeArchived || false,
         },
diff --git a/apps/sim/tools/linear/update_project_milestone.ts b/apps/sim/tools/linear/update_project_milestone.ts
@@ -113,9 +113,17 @@ export const linearUpdateProjectMilestoneTool: ToolConfig<
     }
 
     const result = data.data.projectMilestoneUpdate
+    if (!result.success) {
+      return {
+        success: false,
+        error: 'Project milestone update was not successful',
+        output: {},
+      }
+    }
+
     const milestone = result.projectMilestone
     return {
-      success: result.success,
+      success: true,
       output: {
         projectMilestone: {
           ...milestone,

Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,7 @@ export const linearListCustomerRequestsTool: ToolConfig<`
`88`	`88`	`}`
`89`	`89`	`,
`90`	`90`	`variables: {`
`91`		`- first: params.first \|\| 50,`
	`91`	`+ first: params.first ? Number(params.first) : 50,`
`92`	`92`	`after: params.after,`
`93`	`93`	`includeArchived: params.includeArchived \|\| false,`
`94`	`94`	`},`
Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ export const linearListCustomerStatusesTool: ToolConfig<`
`69`	`69`	`}`
`70`	`70`	`,
`71`	`71`	`variables: {`
`72`		`- first: params.first \|\| 50,`
	`72`	`+ first: params.first ? Number(params.first) : 50,`
`73`	`73`	`after: params.after,`
`74`	`74`	`},`
`75`	`75`	`}),`
Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ export const linearListCustomerTiersTool: ToolConfig<`
`68`	`68`	`}`
`69`	`69`	`,
`70`	`70`	`variables: {`
`71`		`- first: params.first \|\| 50,`
	`71`	`+ first: params.first ? Number(params.first) : 50,`
`72`	`72`	`after: params.after,`
`73`	`73`	`},`
`74`	`74`	`}),`
Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ export const linearListCustomersTool: ToolConfig<`
`75`	`75`	`}`
`76`	`76`	`,
`77`	`77`	`variables: {`
`78`		`- first: params.first \|\| 50,`
	`78`	`+ first: params.first ? Number(params.first) : 50,`
`79`	`79`	`after: params.after,`
`80`	`80`	`includeArchived: params.includeArchived \|\| false,`
`81`	`81`	`},`
Original file line number	Diff line number	Diff line change
`@@ -81,7 +81,7 @@ export const linearListProjectLabelsTool: ToolConfig<`
`81`	`81`	`,
`82`	`82`	`variables: {`
`83`	`83`	`id: params.projectId.trim(),`
`84`		`- first: params.first \|\| 50,`
	`84`	`+ first: params.first ? Number(params.first) : 50,`
`85`	`85`	`after: params.after,`
`86`	`86`	`},`
`87`	`87`	`}`
`@@ -109,7 +109,7 @@ export const linearListProjectLabelsTool: ToolConfig<`
`109`	`109`	`}`
`110`	`110`	`,
`111`	`111`	`variables: {`
`112`		`- first: params.first \|\| 50,`
	`112`	`+ first: params.first ? Number(params.first) : 50,`
`113`	`113`	`after: params.after,`
`114`	`114`	`},`
`115`	`115`	`}`
Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ export const linearListProjectStatusesTool: ToolConfig<`
`70`	`70`	`}`
`71`	`71`	`,
`72`	`72`	`variables: {`
`73`		`- first: params.first \|\| 50,`
	`73`	`+ first: params.first ? Number(params.first) : 50,`
`74`	`74`	`after: params.after,`
`75`	`75`	`},`
`76`	`76`	`}),`
Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,7 @@ export const linearListProjectsTool: ToolConfig<`
`93`	`93`	`}`
`94`	`94`	`,
`95`	`95`	`variables: {`
`96`		`- first: params.first \|\| 50,`
	`96`	`+ first: params.first ? Number(params.first) : 50,`
`97`	`97`	`after: params.after,`
`98`	`98`	`includeArchived: params.includeArchived \|\| false,`
`99`	`99`	`},`