fix(enrichment): show waiting over stale outputs

Author: TheodoreSpeaks

apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table-grid/cells/cell-render.test.ts

@@ -0,0 +1,67 @@
+/**
+ * @vitest-environment node
+ */
+import { describe, expect, it } from 'vitest'
+import type { RowExecutionMetadata } from '@/lib/table'
+import { resolveCellRender } from '@/app/workspace/[workspaceId]/tables/[tableId]/components/table-grid/cells/cell-render'
+import type { DisplayColumn } from '@/app/workspace/[workspaceId]/tables/[tableId]/components/table-grid/types'
+
+const COLUMN: DisplayColumn = {
+  id: 'email',
+  key: 'email',
+  name: 'Email',
+  type: 'string',
+  workflowGroupId: 'group-1',
+  groupSize: 1,
+  groupStartColIndex: 0,
+  headerLabel: 'Email',
+  isGroupStart: true,
+}
+
+function execution(status: RowExecutionMetadata['status']): RowExecutionMetadata {
+  return {
+    status,
+    executionId: 'execution-1',
+    jobId: null,
+    workflowId: 'workflow-1',
+    error: null,
+  }
+}
+
+describe('resolveCellRender waiting precedence', () => {
+  it('shows Waiting instead of a stale enrichment output', () => {
+    expect(
+      resolveCellRender({
+        value: 'person@old.example',
+        exec: undefined,
+        column: COLUMN,
+        waitingOnLabels: ['Domain'],
+        isEnrichmentOutput: true,
+      })
+    ).toEqual({ kind: 'waiting', labels: ['Domain'] })
+  })
+
+  it('shows Waiting over a stale terminal execution', () => {
+    expect(
+      resolveCellRender({
+        value: 'person@old.example',
+        exec: execution('completed'),
+        column: COLUMN,
+        waitingOnLabels: ['Domain'],
+        isEnrichmentOutput: true,
+      })
+    ).toEqual({ kind: 'waiting', labels: ['Domain'] })
+  })
+
+  it('keeps the previous value visible while a replacement is in flight', () => {
+    expect(
+      resolveCellRender({
+        value: 'person@old.example',
+        exec: execution('running'),
+        column: COLUMN,
+        waitingOnLabels: ['Domain'],
+        isEnrichmentOutput: true,
+      })
+    ).toEqual({ kind: 'value', text: 'person@old.example' })
+  })
+})

apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table-grid/cells/cell-render.tsx

@@ -78,6 +78,16 @@ export function resolveCellRender({
       exec?.status === 'running' || exec?.status === 'queued' || exec?.status === 'pending'
     if (inFlight && blockRunning) return { kind: 'running' }
 
+    /**
+     * A mapped-input edit can invalidate an earlier enrichment result without
+     * deleting its stored output. Once no attempt is in flight, the actionable
+     * Waiting state must win over that stale value. Active reruns still keep
+     * showing the previous value until their replacement lands.
+     */
+    if (!inFlight && waitingOnLabels && waitingOnLabels.length > 0) {
+      return { kind: 'waiting', labels: waitingOnLabels }
+    }
+
     // Value wins over pending-upstream: a finished column stays finished even
     // while other blocks in the group are still running. An empty string is not
     // a value — it falls through so a completed enrichment can show "Not found".
@@ -108,10 +118,6 @@ export function resolveCellRender({
       return { kind: 'pending-upstream', paused: false }
     }
 
-    // Waiting wins over a stale terminal status — show the actionable state.
-    if (waitingOnLabels && waitingOnLabels.length > 0) {
-      return { kind: 'waiting', labels: waitingOnLabels }
-    }
     if (exec?.status === 'cancelled') return { kind: 'cancelled' }
     if (exec?.status === 'error') return { kind: 'error', message: exec.error }
     // Enrichment ran to completion but matched nothing → "Not found".