fix(storage): meter copilot ingest centrally for path symmetry

Address Cursor review: only uploadCopilotFile incremented storage, but copilot
files also enter via the generic upload route and presigned uploads — all of
which persist metadata through insertFileMetadata. Move the increment into
insertFileMetadata (scoped to context='copilot', on genuine insert/restore) so
every ingest path is symmetric with the delete-time decrement, and drop the now
redundant per-path increment in uploadCopilotFile. Other contexts are metered by
their own managers and remain unaffected.

Author: waleedlatif1

apps/sim/lib/uploads/contexts/copilot/copilot-file-manager.ts

@@ -1,9 +1,5 @@
 import { createLogger } from '@sim/logger'
-import {
-  checkStorageQuota,
-  incrementStorageUsage,
-  releaseDeletedFileStorage,
-} from '@/lib/billing/storage'
+import { checkStorageQuota, releaseDeletedFileStorage } from '@/lib/billing/storage'
 import { getBaseUrl } from '@/lib/core/utils/urls'
 import {
   deleteFile,
@@ -148,12 +144,9 @@ export async function uploadCopilotFile(options: {
     userId: options.userId,
   })
 
-  try {
-    await incrementStorageUsage(options.userId, options.buffer.length)
-  } catch (storageError) {
-    logger.error('Failed to update storage tracking:', storageError)
-  }
-
+  // Storage is metered centrally when the copilot metadata row is created
+  // (see insertFileMetadata), so every ingest path stays symmetric — no
+  // per-path increment here.
   return {
     id: fileInfo.key,
     key: fileInfo.key,

apps/sim/lib/uploads/server/metadata.ts

@@ -7,6 +7,28 @@ import type { StorageContext } from '../shared/types'
 
 const logger = createLogger('FileMetadata')
 
+/**
+ * Meter a copilot file's bytes against the owner's storage quota when its
+ * metadata row is first created or restored. Copilot is the one context metered
+ * here so that every ingest path (tool output, the upload route, presigned
+ * uploads) is symmetric with the decrement on delete. Other contexts are metered
+ * by their own managers (workspace, knowledge-base) or intentionally unmetered
+ * (execution), so they are skipped. Best-effort: never blocks the metadata write.
+ */
+async function meterCopilotIngest(
+  context: StorageContext,
+  userId: string,
+  size: number
+): Promise<void> {
+  if (context !== 'copilot' || size <= 0) return
+  try {
+    const { incrementStorageUsage } = await import('@/lib/billing/storage')
+    await incrementStorageUsage(userId, size)
+  } catch (error) {
+    logger.error('Failed to meter copilot file storage on ingest', { error })
+  }
+}
+
 export type FileMetadataRecord = typeof workspaceFiles.$inferSelect
 
 export interface FileMetadataInsertOptions {
@@ -57,6 +79,7 @@ export async function insertFileMetadata(
       .returning()
 
     if (restored) {
+      await meterCopilotIngest(context, userId, size)
       return restored
     }
   }
@@ -92,6 +115,7 @@ export async function insertFileMetadata(
       })
       .returning()
 
+    await meterCopilotIngest(context, userId, size)
     return inserted
   } catch (error) {
     const code = (error as { code?: string } | null)?.code