fix(env): allow zero in envNumber for max-throughput configs

Author: waleedlatif1

apps/sim/lib/core/config/env.ts

@@ -517,16 +517,18 @@ export { getEnv }
 
 /**
  * Coerce an env-derived value to a positive finite number, falling back to the
- * provided default when the value is unset, empty, non-finite, or ≤ 0.
+ * provided default when the value is unset, empty, non-finite, or negative.
+ * Zero is accepted — some configs (e.g. `KB_CONFIG_DELAY_BETWEEN_BATCHES`)
+ * use `0` to mean "no delay / max throughput".
  *
  * `createEnv` is configured with `skipValidation: true`, so values declared as
  * `z.number()` arrive as raw strings when sourced from `process.env` or Helm.
  * Use this helper anywhere a numeric env override is consumed to normalize the
  * type at the boundary instead of relying on JS implicit coercion.
  */
 export function envNumber(value: number | string | undefined | null, fallback: number): number {
-  if (typeof value === 'number' && Number.isFinite(value) && value > 0) return value
+  if (typeof value === 'number' && Number.isFinite(value) && value >= 0) return value
   if (value === undefined || value === null || value === '') return fallback
   const parsed = Number(value)
-  return Number.isFinite(parsed) && parsed > 0 ? parsed : fallback
+  return Number.isFinite(parsed) && parsed >= 0 ? parsed : fallback
 }

packages/testing/src/mocks/env.mock.ts

@@ -54,10 +54,10 @@ export function createEnvMock(overrides: Record<string, string | undefined> = {}
         ? value.toLowerCase() === 'false' || value === '0'
         : value === false,
     envNumber: (value: number | string | undefined | null, fallback: number): number => {
-      if (typeof value === 'number' && Number.isFinite(value) && value > 0) return value
+      if (typeof value === 'number' && Number.isFinite(value) && value >= 0) return value
       if (value === undefined || value === null || value === '') return fallback
       const parsed = Number(value)
-      return Number.isFinite(parsed) && parsed > 0 ? parsed : fallback
+      return Number.isFinite(parsed) && parsed >= 0 ? parsed : fallback
     },
   }
 }