fix(connectors): address PR review comments - metadata merge, retryOptions, UTF-8 safety

- Sync engine: merge metadata from getDocument during deferred hydration,
  so Gmail/Obsidian/Confluence tags and metadata survive the stub→full transition
- Evernote: pass retryOptions {retries:3, backoff:500} from listDocuments and
  getDocument callers into apiFindNotesMetadata and apiGetNote
- Google Drive + SharePoint: safe UTF-8 truncation that walks back to the last
  complete character boundary instead of splitting multi-byte chars

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: waleedlatif1

apps/sim/connectors/evernote/evernote.ts

@@ -412,7 +412,14 @@ export const evernoteConnector: ConnectorConfig = {
 
     logger.info('Listing Evernote notes', { offset, maxNotes: NOTES_PER_PAGE })
 
-    const result = await apiFindNotesMetadata(accessToken, offset, NOTES_PER_PAGE, notebookGuid)
+    const retryOptions = { retries: 3, backoff: 500 }
+    const result = await apiFindNotesMetadata(
+      accessToken,
+      offset,
+      NOTES_PER_PAGE,
+      notebookGuid,
+      retryOptions
+    )
 
     const documents: ExternalDocument[] = result.notes.map((meta) => {
       const tagNames = meta.tagGuids.map((g) => tagMap[g]).filter(Boolean)
@@ -451,7 +458,8 @@ export const evernoteConnector: ConnectorConfig = {
     syncContext?: Record<string, unknown>
   ): Promise<ExternalDocument | null> => {
     try {
-      const note = await apiGetNote(accessToken, externalId)
+      const retryOptions = { retries: 3, backoff: 500 }
+      const note = await apiGetNote(accessToken, externalId, retryOptions)
       const plainText = htmlToPlainText(note.content)
       if (!plainText.trim()) return null
 

apps/sim/connectors/google-drive/google-drive.ts

@@ -70,7 +70,10 @@ async function downloadTextFile(accessToken: string, fileId: string): Promise<st
   const text = await response.text()
   if (Buffer.byteLength(text, 'utf8') > MAX_EXPORT_SIZE) {
     logger.warn(`File exceeds ${MAX_EXPORT_SIZE} bytes, truncating`)
-    return Buffer.from(text, 'utf8').subarray(0, MAX_EXPORT_SIZE).toString('utf8')
+    const buf = Buffer.from(text, 'utf8')
+    let end = MAX_EXPORT_SIZE
+    while (end > 0 && (buf[end] & 0xc0) === 0x80) end--
+    return buf.subarray(0, end).toString('utf8')
   }
   return text
 }

apps/sim/connectors/sharepoint/sharepoint.ts

@@ -135,7 +135,10 @@ async function downloadFileContent(
   const text = await response.text()
   if (Buffer.byteLength(text, 'utf8') > MAX_DOWNLOAD_SIZE) {
     logger.warn(`File "${fileName}" exceeds ${MAX_DOWNLOAD_SIZE} bytes, truncating`)
-    return Buffer.from(text, 'utf8').subarray(0, MAX_DOWNLOAD_SIZE).toString('utf8')
+    const buf = Buffer.from(text, 'utf8')
+    let end = MAX_DOWNLOAD_SIZE
+    while (end > 0 && (buf[end] & 0xc0) === 0x80) end--
+    return buf.subarray(0, end).toString('utf8')
   }
   return text
 }

apps/sim/lib/knowledge/connectors/sync-engine.ts

@@ -463,6 +463,7 @@ export async function executeSync(
                 content: fullDoc.content,
                 contentHash: fullDoc.contentHash ?? op.extDoc.contentHash,
                 contentDeferred: false,
+                metadata: { ...op.extDoc.metadata, ...fullDoc.metadata },
               },
             }
           })