@@ -77,6 +77,147 @@ async function change(input: HTMLInputElement, value: string) {
7777}
7878
7979describe ( 'shared secrets editor' , ( ) => {
80+ it . each ( [ 'existing value' , 'remove new row' ] ) (
81+ 'preserves the surviving shared secret when a submitted duplicate changes: %s' ,
82+ async ( changeKind ) => {
83+ const request = createDeferred < void > ( )
84+ const persisted : Record < string , string > = { TOKEN : 'original' }
85+ let first = true
86+ await render ( {
87+ variables : { TOKEN : 'original' } ,
88+ save : async ( { upsert, remove } ) => {
89+ if ( first ) {
90+ first = false
91+ await request . promise
92+ }
93+ for ( const key of remove ) delete persisted [ key ]
94+ Object . assign ( persisted , upsert )
95+ } ,
96+ } )
97+ const key = container . querySelector < HTMLInputElement > ( 'input[name^="new_workspace_key_"]' )
98+ const value = container . querySelector < HTMLInputElement > ( 'input[name^="new_workspace_value_"]' )
99+ const existing = container . querySelector < HTMLInputElement > (
100+ 'input[name^="workspace_env_value_TOKEN"]'
101+ )
102+ if ( ! key || ! value || ! existing ) throw new Error ( 'Missing shared secret rows' )
103+ await change ( key , 'TOKEN' )
104+ await change ( value , 'submitted' )
105+ act ( ( ) => button ( 'Save' ) . click ( ) )
106+ if ( changeKind === 'existing value' ) await change ( existing , 'later' )
107+ else {
108+ await change ( key , '' )
109+ await change ( value , '' )
110+ }
111+ await act ( async ( ) => request . resolve ( ) )
112+ await act ( async ( ) => button ( 'Save' ) . click ( ) )
113+ expect ( persisted ) . toEqual ( { TOKEN : changeKind === 'existing value' ? 'later' : 'original' } )
114+ }
115+ )
116+
117+ it . each ( [ 'rename' , 'value' , 'delete' ] ) (
118+ 'rebases a new shared secret row changed during Save: %s' ,
119+ async ( changeKind ) => {
120+ const request = createDeferred < void > ( )
121+ const persisted : Record < string , string > = { }
122+ let first = true
123+ await render ( {
124+ save : async ( { upsert, remove } ) => {
125+ if ( first ) {
126+ first = false
127+ await request . promise
128+ }
129+ for ( const key of remove ) delete persisted [ key ]
130+ Object . assign ( persisted , upsert )
131+ } ,
132+ } )
133+ const key = container . querySelector < HTMLInputElement > ( 'input[name^="new_workspace_key_"]' )
134+ const value = container . querySelector < HTMLInputElement > ( 'input[name^="new_workspace_value_"]' )
135+ if ( ! key || ! value ) throw new Error ( 'Missing new shared secret row' )
136+ await change ( key , 'TOKEN' )
137+ await change ( value , 'submitted' )
138+ act ( ( ) => button ( 'Save' ) . click ( ) )
139+ if ( changeKind === 'rename' ) await change ( key , 'RENAMED' )
140+ else if ( changeKind === 'value' ) await change ( value , 'later' )
141+ else {
142+ await change ( key , '' )
143+ await change ( value , '' )
144+ }
145+ await act ( async ( ) => request . resolve ( ) )
146+ const populated = [
147+ ...container . querySelectorAll < HTMLInputElement > ( 'input[name*="value"]' ) ,
148+ ] . filter ( ( field ) => field . value )
149+ expect ( populated ) . toHaveLength ( changeKind === 'delete' ? 0 : 1 )
150+ await act ( async ( ) => button ( 'Save' ) . click ( ) )
151+ expect ( persisted ) . toEqual (
152+ changeKind === 'delete'
153+ ? { }
154+ : changeKind === 'rename'
155+ ? { RENAMED : 'submitted' }
156+ : { TOKEN : 'later' }
157+ )
158+ }
159+ )
160+
161+ it . each ( [ '' , 'remotely-populated' ] ) (
162+ 'preserves a saved empty personal secret refreshed to %s while saving another edited secret' ,
163+ async ( remoteValue ) => {
164+ let persisted : unknown
165+ const personal = {
166+ variables : {
167+ EMPTY : { key : 'EMPTY' , value : '' } ,
168+ TOKEN : { key : 'TOKEN' , value : 'original' } ,
169+ } ,
170+ save : async ( variables : Record < string , string > ) => {
171+ persisted = variables
172+ } ,
173+ }
174+ await render ( { personal } )
175+ const fields = [
176+ ...container . querySelectorAll < HTMLInputElement > ( 'input[name^="env_variable_value_"]' ) ,
177+ ]
178+ const token = fields . find ( ( field ) => field . value === 'original' )
179+ if ( ! token ) throw new Error ( 'Missing saved token' )
180+ await change ( token , 'updated' )
181+ await render ( {
182+ personal : {
183+ ...personal ,
184+ variables : { ...personal . variables , EMPTY : { key : 'EMPTY' , value : remoteValue } } ,
185+ } ,
186+ } )
187+ await act ( async ( ) => button ( 'Save' ) . click ( ) )
188+ expect ( persisted ) . toEqual ( { EMPTY : remoteValue , TOKEN : 'updated' } )
189+ let left = false
190+ act ( ( ) =>
191+ useSettingsDirtyStore . getState ( ) . requestLeave ( ( ) => {
192+ left = true
193+ } )
194+ )
195+ expect ( left ) . toBe ( true )
196+ }
197+ )
198+
199+ it ( 'persists deletion of a saved empty personal secret' , async ( ) => {
200+ let persisted : unknown
201+ await render ( {
202+ personal : {
203+ variables : {
204+ EMPTY : { key : 'EMPTY' , value : '' } ,
205+ TOKEN : { key : 'TOKEN' , value : 'original' } ,
206+ } ,
207+ save : async ( variables ) => {
208+ persisted = variables
209+ } ,
210+ } ,
211+ } )
212+ const empty = [
213+ ...container . querySelectorAll < HTMLInputElement > ( 'input[name^="env_variable_name_"]' ) ,
214+ ] . find ( ( field ) => field . value === 'EMPTY' )
215+ if ( ! empty ) throw new Error ( 'Missing empty secret' )
216+ await change ( empty , '' )
217+ await act ( async ( ) => button ( 'Save' ) . click ( ) )
218+ expect ( persisted ) . toEqual ( { TOKEN : 'original' } )
219+ } )
220+
80221 it . each ( [
81222 { scope : 'workspace' , kind : 'key' , prefix : 'new_workspace_key_' } ,
82223 { scope : 'workspace' , kind : 'value' , prefix : 'new_workspace_value_' } ,
0 commit comments