Commit 0bff854
committed
fix(dataverse): reject port-qualified origins, refuse reconnect without a host
- resolve: an explicit port survived into the origin, which becomes both the
OAuth audience and the API base. Providers publish their resource on the
default port, so a port-qualified origin names a resource nobody serves.
`URL` drops the port only when it is the scheme default, so anything left is
explicit and now rejected.
- reconnect: the credential-detail Reconnect action calls the connect mutation
directly with no environment URL, so a resource-scoped service failed with a
validator error about a field that surface never shows. It now refuses up
front with the route that works. The check runs before the draft is written,
so a refusal leaves nothing behind.
`WorkspaceCredential` carries no granted scopes, so the origin cannot be read
back off the credential here — that is the follow-up already noted on the PR.1 parent f881696 commit 0bff854
3 files changed
Lines changed: 32 additions & 0 deletions
File tree
- apps/sim
- app/workspace/[workspaceId]/integrations/connected/[credentialId]
- lib/oauth
Lines changed: 14 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| 22 | + | |
22 | 23 | | |
23 | 24 | | |
24 | 25 | | |
| |||
113 | 114 | | |
114 | 115 | | |
115 | 116 | | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
116 | 130 | | |
117 | 131 | | |
118 | 132 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
44 | 53 | | |
45 | 54 | | |
46 | 55 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
43 | 52 | | |
44 | 53 | | |
45 | 54 | | |
| |||
0 commit comments