fix(logs): preserve markers when the completion read fails

getProgressMarkers now returns null on a Redis read error (vs {} for genuinely empty). completeWorkflowExecution and markExecutionAsFailed skip clearProgressMarkers when the read returns null, so a transient read error at completion no longer wipes markers that are still durably in Redis — the TTL reclaims them instead.

Author: waleedlatif1

apps/sim/lib/logs/execution/logger.ts

@@ -749,7 +749,7 @@ export class ExecutionLogger implements IExecutionLoggerService {
 
     const builtExecutionData = this.buildCompletedExecutionData({
       existingExecutionData,
-      progressMarkers,
+      progressMarkers: progressMarkers ?? undefined,
       traceSpans: mergedTraceSpans,
       finalOutput,
       finalizationPath,
@@ -910,7 +910,7 @@ export class ExecutionLogger implements IExecutionLoggerService {
       return log
     })
 
-    void clearProgressMarkers(executionId)
+    if (progressMarkers !== null) void clearProgressMarkers(executionId)
 
     try {
       // Skip workflow lookup if workflow was deleted.

apps/sim/lib/logs/execution/logging-session.test.ts

@@ -699,6 +699,12 @@ describe('LoggingSession.markExecutionAsFailed workflowId scoping', () => {
     expect(folded).toContain('lastCompletedBlock')
     expect(clearProgressMarkersMock).toHaveBeenCalledWith('exec-9')
   })
+
+  it('does not clear markers when the Redis read fails (avoids wiping the only copy)', async () => {
+    getProgressMarkersMock.mockResolvedValueOnce(null)
+    await LoggingSession.markExecutionAsFailed('exec-readfail', 'boom', undefined, 'wf-x')
+    expect(clearProgressMarkersMock).not.toHaveBeenCalled()
+  })
 })
 
 describe('LoggingSession progress-marker write path', () => {

apps/sim/lib/logs/execution/logging-session.ts

@@ -1059,10 +1059,10 @@ export class LoggingSession {
             ARRAY['finalizationPath'],
             to_jsonb('force_failed'::text)
           )`
-      if (markers.lastStartedBlock) {
+      if (markers?.lastStartedBlock) {
         executionData = sql`jsonb_set(${executionData}, ARRAY['lastStartedBlock'], ${JSON.stringify(markers.lastStartedBlock)}::jsonb)`
       }
-      if (markers.lastCompletedBlock) {
+      if (markers?.lastCompletedBlock) {
         executionData = sql`jsonb_set(${executionData}, ARRAY['lastCompletedBlock'], ${JSON.stringify(markers.lastCompletedBlock)}::jsonb)`
       }
 
@@ -1076,7 +1076,7 @@ export class LoggingSession {
           )
         )
 
-      void clearProgressMarkers(executionId)
+      if (markers !== null) void clearProgressMarkers(executionId)
 
       logger.info(`[${requestId || 'unknown'}] Marked execution ${executionId} as failed`)
     } catch (error) {

apps/sim/lib/logs/execution/progress-markers.test.ts

@@ -151,6 +151,11 @@ describe('progress-markers', () => {
       expect(await getProgressMarkers(EXECUTION_ID)).toEqual({})
       expect(mockRedis.hgetall).not.toHaveBeenCalled()
     })
+
+    it('returns null when the Redis read fails so callers do not clear the only copy', async () => {
+      mockRedis.hgetall.mockRejectedValueOnce(new Error('redis down'))
+      expect(await getProgressMarkers(EXECUTION_ID)).toBeNull()
+    })
   })
 
   describe('clearProgressMarkers', () => {

apps/sim/lib/logs/execution/progress-markers.ts

@@ -176,9 +176,14 @@ function parseCompletedMarker(raw: string | undefined): ExecutionLastCompletedBl
 
 /**
  * Read both markers for an execution. Returns an empty object when Redis is
- * unavailable, the key has expired, or nothing has been written yet.
+ * unavailable (markers were never stored here) or the key holds nothing, and
+ * `null` when the Redis read itself failed — callers must treat `null` as
+ * "unknown" and skip {@link clearProgressMarkers}, so a transient read error
+ * never wipes the only copy of markers that are still in Redis.
  */
-export async function getProgressMarkers(executionId: string): Promise<ExecutionProgressMarkers> {
+export async function getProgressMarkers(
+  executionId: string
+): Promise<ExecutionProgressMarkers | null> {
   const redis = getMarkerClient()
   if (!redis) return {}
 
@@ -196,7 +201,7 @@ export async function getProgressMarkers(executionId: string): Promise<Execution
     logger.error(`Failed to read progress markers for execution ${executionId}`, {
       error: toError(error).message,
     })
-    return {}
+    return null
   }
 }
 

apps/sim/lib/logs/fetch-log-detail.ts

@@ -172,7 +172,7 @@ export async function fetchLogDetail({
 
     const liveMarkers =
       log.status === 'running' || log.status === 'pending'
-        ? await getProgressMarkers(log.executionId)
+        ? ((await getProgressMarkers(log.executionId)) ?? {})
         : {}
 
     return {