fix(desktop): an import the rate limit never let start stays safe to ask for again

When Sim's rate limit outlasts every retry, it refused the entry outright,
so the result lists exactly what landed instead of being outcome unknown.
An import where nothing landed is no longer marked do-not-retry.

Author: waleedlatif1

apps/desktop/src/main/desktop-executor/runner.test.ts

@@ -271,6 +271,19 @@ describe('background imports', () => {
     ])
   })
 
+  it('reports an import the rate limit never let start as safe to ask for again', async () => {
+    const sim = recordingSim(() => new DeviceRequestError(429, 'Too many requests', 1))
+    const completion = await runner({ imports: { importEntry: sim.importEntry } }).run(
+      importCall(await reportsFolder()),
+      new AbortController().signal
+    )
+
+    expect(completion.status).toBe('error')
+    expect(completion.data).toMatchObject({ partial: false, files: [], folders: [] })
+    expect(completion.data).not.toHaveProperty('doNotRetry')
+    expect(completion.data).not.toHaveProperty('outcomeUnknown')
+  })
+
   it('fails without storing anything when the source cannot be read', async () => {
     const sim = recordingSim()
     const completion = await runner({ imports: { importEntry: sim.importEntry } }).run(

apps/desktop/src/main/desktop-executor/runner.ts

@@ -321,7 +321,9 @@ export function createDesktopToolRunner(deps: DesktopToolRunnerDeps): DesktopToo
       return localFileImportCompletion(
         localFileImportFailure(
           { workspaceId: targetWorkspaceId, files, folders },
-          getErrorMessage(error)
+          getErrorMessage(error),
+          // A rate limit that outlasted every retry refused the entry outright: nothing of it landed.
+          { outcomeKnown: error instanceof DeviceRequestError && error.status === 429 }
         )
       )
     }

packages/desktop-bridge/src/tool-results.ts

@@ -305,20 +305,24 @@ export interface DesktopLocalFileImportResult {
 }
 
 /**
- * An import that stopped part way. Files it already created stay; whether more landed than it
- * reports is unknown, so the model inspects the workspace instead of importing again.
+ * An import that stopped part way. Files it already created stay. Usually whether more landed than
+ * it reports is unknown, so the model inspects the workspace instead of importing again. With
+ * `outcomeKnown` (Sim refused the next entry outright), the list is exact, and an import where
+ * nothing landed can simply be asked for again.
  */
 export function localFileImportFailure(
   partial: Pick<DesktopLocalFileImportResult, 'workspaceId' | 'files' | 'folders'>,
-  error: string
+  error: string,
+  options: { outcomeKnown?: boolean } = {}
 ): DesktopLocalFileImportResult {
+  const landed = partial.files.length > 0 || partial.folders.length > 0
   return {
     success: false,
     ...partial,
     error,
-    partial: partial.files.length > 0 || partial.folders.length > 0,
-    doNotRetry: true,
-    outcomeUnknown: true,
+    partial: landed,
+    ...(landed || !options.outcomeKnown ? { doNotRetry: true as const } : {}),
+    ...(options.outcomeKnown ? {} : { outcomeUnknown: true as const }),
   }
 }