fix(deploy): keep public API exposure admin-only

Deploying moved to write, but enabling the public API is a different risk
class: it makes the workflow callable with no authentication at all,
exposing every credential and environment variable it references to
anonymous callers. An editor can ship a version; only an admin can expose
it to the internet.

- workflows.public_api.update goes back to minimumRole 'admin'
- the Access control in Edit API Info is disabled for non-admins, with a
  tooltip explaining why

The whole ButtonGroup is gated rather than just the Public option: an
already-public workflow would otherwise let an editor switch it back to
API Key and hit a 403, which is the client/server disagreement this is
meant to avoid. An editor still sees the current state, just cannot
change it either way.

Author: mzxchandra

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/deploy/components/deploy-modal/components/general/components/api-info-modal.tsx

@@ -14,13 +14,15 @@ import {
   ChipModalHeader,
   Input,
   Label,
+  Tooltip,
 } from '@sim/emcn'
 import { getErrorMessage } from '@sim/utils/errors'
 import { useParams } from 'next/navigation'
 import { getMeaningfulWorkflowDescription } from '@/lib/mcp/workflow-tool-schema'
 import { normalizeInputFormatValue } from '@/lib/workflows/input-format'
 import { isInputDefinitionTrigger } from '@/lib/workflows/triggers/input-definition-triggers'
 import type { InputFormatField } from '@/lib/workflows/types'
+import { useUserPermissionsContext } from '@/app/workspace/[workspaceId]/providers/workspace-permissions-provider'
 import { useDeploymentInfo, useUpdatePublicApi } from '@/hooks/queries/deployments'
 import { useUpdateWorkflow, useWorkflowMap } from '@/hooks/queries/workflows'
 import { usePermissionConfig } from '@/hooks/use-permission-config'
@@ -51,6 +53,12 @@ export function ApiInfoModal({ open, onOpenChange, workflowId }: ApiInfoModalPro
   const { data: deploymentData } = useDeploymentInfo(workflowId, { enabled: open })
   const updatePublicApiMutation = useUpdatePublicApi()
   const { isPublicApiDisabled } = usePermissionConfig()
+  /**
+   * Deploying only needs `write`, but exposing a workflow to unauthenticated
+   * callers stays admin-only — `workflowOperations.updatePublicApi` enforces
+   * the same boundary server-side.
+   */
+  const { canAdmin: canSetPublicAccess } = useUserPermissionsContext()
 
   const [description, setDescription] = useState('')
   const [paramDescriptions, setParamDescriptions] = useState<Record<string, string>>({})
@@ -218,13 +226,23 @@ export function ApiInfoModal({ open, onOpenChange, workflowId }: ApiInfoModalPro
 
           {!isPublicApiDisabled && (
             <ChipModalField type='custom' title='Access'>
-              <ButtonGroup
-                value={accessMode}
-                onValueChange={(val) => setAccessMode(val as 'api_key' | 'public')}
-              >
-                <ButtonGroupItem value='api_key'>API Key</ButtonGroupItem>
-                <ButtonGroupItem value='public'>Public</ButtonGroupItem>
-              </ButtonGroup>
+              <Tooltip.Root>
+                <Tooltip.Trigger asChild>
+                  <span className='inline-flex w-fit'>
+                    <ButtonGroup
+                      value={accessMode}
+                      onValueChange={(val) => setAccessMode(val as 'api_key' | 'public')}
+                      disabled={!canSetPublicAccess}
+                    >
+                      <ButtonGroupItem value='api_key'>API Key</ButtonGroupItem>
+                      <ButtonGroupItem value='public'>Public</ButtonGroupItem>
+                    </ButtonGroup>
+                  </span>
+                </Tooltip.Trigger>
+                {!canSetPublicAccess && (
+                  <Tooltip.Content>Only admins can change public API access</Tooltip.Content>
+                )}
+              </Tooltip.Root>
               <p className='mt-1 text-[var(--text-secondary)] text-caption'>
                 {accessMode === 'public'
                   ? 'Anyone can call this API without authentication. You will be billed for all usage.'

apps/sim/lib/core/application/deployment-permission-matrix.test.ts

@@ -24,7 +24,6 @@ describe('deployment permission matrix', () => {
       ['undeploy', workflowOperations.undeploy],
       ['deployChat', workflowOperations.deployChat],
       ['undeployChat', workflowOperations.undeployChat],
-      ['updatePublicApi', workflowOperations.updatePublicApi],
       ['activateVersion', workflowOperations.activateVersion],
       ['revertVersion', workflowOperations.revertVersion],
       ['updateVersion', workflowOperations.updateVersion],
@@ -43,14 +42,23 @@ describe('deployment permission matrix', () => {
     })
   })
 
-  describe('credential and code-injection surfaces stay admin', () => {
+  describe('credential, exposure, and code-injection surfaces stay admin', () => {
     it('minting a workspace API key requires admin', () => {
       expect(apiKeyOperations.createFromCopilot.minimumRole).toBe('admin')
     })
 
     it('workflow policy (lock) requires admin', () => {
       expect(workflowOperations.updatePolicy.minimumRole).toBe('admin')
     })
+
+    /**
+     * Enabling the public API makes the workflow callable with no auth at all.
+     * It stays admin even though deploying moved to write — an editor can ship
+     * a version, but only an admin can expose it to anonymous callers.
+     */
+    it('exposing a workflow as a public API requires admin', () => {
+      expect(workflowOperations.updatePublicApi.minimumRole).toBe('admin')
+    })
   })
 
   /**

apps/sim/lib/workflows/application/operations.ts

@@ -202,9 +202,15 @@ export const workflowOperations = {
     workspaceApiKey: 'deny',
     ...HUMAN_WORKFLOW_PRINCIPAL_POLICY,
   }),
+  /**
+   * Deliberately admin while the rest of the deployment lifecycle is write:
+   * enabling this makes the workflow callable with no authentication at all,
+   * exposing every credential and environment variable it references to
+   * anonymous callers. That is a different risk class from shipping a version.
+   */
   updatePublicApi: defineWorkspaceOperation({
     id: 'workflows.public_api.update',
-    minimumRole: 'write',
+    minimumRole: 'admin',
     workspaceApiKey: 'deny',
     principalKinds: ['session'],
   }),