Commit 0249516
authored
fix(compare): swap LangChain logo, fix comparison-table horizontal scroll (#5409)
* fix(compare): swap LangChain logo, fix comparison-table horizontal scroll
Replace LangChainIcon's path with the official brand mark (light-blue
link icon) instead of the prior monochrome recreation.
The comparison table's grid cells were missing min-w-0, so a grid item
without it sizes to its content's max-content width instead of
respecting its column's fr track, pushing the whole table wider than
its container and forcing a horizontal scrollbar. Add min-w-0 to every
grid cell/header, and size the row-label column to minmax(140px,
max-content) instead of a guessed fr ratio, so it's exactly as wide as
its longest label ("Vetted first-party integrations") needs and no
wider, leaving the Sim/competitor value columns their full share.
* fix(compare): stacked mobile layout for the comparison table
Below sm (640px) a 3-column table has no room to be legible even with
the sticky label column, so switch to the standard responsive-table
pattern instead: each fact stacks as label -> Sim's value -> the
competitor's value, each value tagged with its product name since the
column headers are no longer directly above. Pure CSS (max-sm:/sm:
variants), no JS, keeping this a zero-hydration server component.
* fix(compare): fix SourceLink inline-anchor overflow, align table breakpoint
Root cause of the persistent table-overflow/mobile-scroll issues: SourceLink
renders a plain <a> with no explicit display, so it defaults to
'display: inline'. min-width and truncate are no-ops on inline elements, so
any fact with a source (nearly all of them) ignored its flex/grid parent's
width constraint and could force the whole row (and thus the whole table)
wider than intended, regardless of any container-level min-w-0/max-content
fix. Give the anchor 'block min-w-0' so width constraints and truncation
actually cascade down to the wrapped value.
Also aligns the table's mobile-stack breakpoint from an ad hoc sm (640px) to
lg (1024px), matching this route group's own tablet-and-below convention
(.claude/rules for the (landing) group), and fixes the stacked mobile cells
to override the cell's base items-center with items-stretch so the name tag
and value get a real full-width box to truncate within instead of shrinking
to their own content size with no boundary.
* fix(compare): add min-w-0 to ColumnHeader per Greptile review
ColumnHeader (the Sim/competitor logo header cells in the two fr columns)
still had default min-width: auto, so an unusually long competitor name
could size the header to its min-content width and push the grid wider
than its column allows, same root cause as the rows already fixed.1 parent 759dddb commit 0249516
3 files changed
Lines changed: 72 additions & 15 deletions
File tree
- apps/sim
- app/(landing)/comparison/components
- comparison-table
- source-info
- components
Lines changed: 68 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
13 | 46 | | |
14 | 47 | | |
15 | 48 | | |
| |||
22 | 55 | | |
23 | 56 | | |
24 | 57 | | |
25 | | - | |
| 58 | + | |
26 | 59 | | |
27 | 60 | | |
28 | 61 | | |
29 | 62 | | |
30 | | - | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
31 | 66 | | |
32 | 67 | | |
33 | 68 | | |
| |||
49 | 84 | | |
50 | 85 | | |
51 | 86 | | |
52 | | - | |
| 87 | + | |
53 | 88 | | |
54 | 89 | | |
55 | 90 | | |
56 | 91 | | |
57 | | - | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
58 | 97 | | |
59 | | - | |
60 | | - | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
61 | 102 | | |
62 | 103 | | |
63 | 104 | | |
| |||
89 | 130 | | |
90 | 131 | | |
91 | 132 | | |
| 133 | + | |
| 134 | + | |
92 | 135 | | |
93 | 136 | | |
94 | 137 | | |
| |||
99 | 142 | | |
100 | 143 | | |
101 | 144 | | |
102 | | - | |
| 145 | + | |
103 | 146 | | |
104 | 147 | | |
105 | 148 | | |
| |||
115 | 158 | | |
116 | 159 | | |
117 | 160 | | |
118 | | - | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
119 | 164 | | |
120 | 165 | | |
121 | 166 | | |
122 | | - | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
123 | 170 | | |
124 | 171 | | |
125 | 172 | | |
126 | 173 | | |
127 | | - | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
128 | 177 | | |
129 | 178 | | |
130 | 179 | | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
131 | 183 | | |
132 | 184 | | |
133 | 185 | | |
134 | 186 | | |
135 | 187 | | |
136 | | - | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
137 | 191 | | |
138 | 192 | | |
139 | 193 | | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
140 | 197 | | |
141 | 198 | | |
142 | 199 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
| 4 | + | |
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
| 32 | + | |
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1565 | 1565 | | |
1566 | 1566 | | |
1567 | 1567 | | |
1568 | | - | |
1569 | | - | |
| 1568 | + | |
| 1569 | + | |
1570 | 1570 | | |
1571 | 1571 | | |
1572 | 1572 | | |
| |||
0 commit comments