Turn Order and Action Advance logic

[kdovtdc]

These two bugs are related to the Turn logic:

• Currently in sim, an Action Advance for multiple targets is handled each target at a time, going in order of the individual implementation's logic (e.g., Dance! Dance! Dance! goes through the list of characters in order of which they were added). This causes erroneus behavior when two targets (target 3 and target 4, where neither of them is taking the current turn) are tied at 0 AV and receive the AA from DDD, where target 4 now takes their next turn before target 3.
  How it should work is that the turn order of the two targets is kept the same as before.
• Additionally, in sim, Bronya's "AA" from Skill when targeted at target 4 – at the same situation of being tied at 0 AV with target 3 – does not make target 4 take turn before target 3, while it does ingame.

used config:
bronya_avtie.txt

[kdovtdc]

The explanations for these bugs are as follows:

• When DDD's AA (S5) effect is triggered at 0 AV for targets 3 and 4, sim's logic will reduce all characters' gauges by 2400, which succeeds and targets 3 and 4 will subsequently have their AG set to -2400 (-24 AV).* When ModifyGaugeNormalized -> SetGauge is called for target 4, target 4 is sorted above target 3 before doing sort.Stable (this is likely part of the logic to handle advances into ties making the advanced target go before any other tied target).
• When Bronya uses Skill to "AA" target 4 at 0 AG, SetGauge is called with data.Amount set to 0, which causes an early exit, making the logic not run through the part to handle advances into ties (see bug 1).

*: This is another bug as AG/AV cannot become negative under currently known circumstances, which also causes StartTurn to add a positive AG amount to all targets.