Don't disable ratcheting when closing a session

liliakai · liliakai · commit bea0c3b792ee · 2016-07-31T23:20:57.000-07:00
It is possible to receive a ratchet-step message for a closed session,
in which case we need these keys around to decrypt it.
diff --git a/dist/libsignal-protocol.js b/dist/libsignal-protocol.js
@@ -35705,9 +35705,6 @@ Internal.SessionRecord = function() {
                     };
                 }
             }
-            // Delete current root key and our ephemeral key pair to disallow ratchet stepping
-            delete session.currentRatchet.rootKey;
-            delete session.currentRatchet.ephemeralKeyPair;
             session.indexInfo.closed = Date.now();
             this.removeOldChains(session);
         },
diff --git a/src/SessionRecord.js b/src/SessionRecord.js
@@ -210,9 +210,6 @@ Internal.SessionRecord = function() {
                     };
                 }
             }
-            // Delete current root key and our ephemeral key pair to disallow ratchet stepping
-            delete session.currentRatchet.rootKey;
-            delete session.currentRatchet.ephemeralKeyPair;
             session.indexInfo.closed = Date.now();
             this.removeOldChains(session);
         },

Original file line number	Diff line number	Diff line change
`@@ -35705,9 +35705,6 @@ Internal.SessionRecord = function() {`
`35705`	`35705`	`};`
`35706`	`35706`	`}`
`35707`	`35707`	`}`
`35708`		`- // Delete current root key and our ephemeral key pair to disallow ratchet stepping`
`35709`		`- delete session.currentRatchet.rootKey;`
`35710`		`- delete session.currentRatchet.ephemeralKeyPair;`
`35711`	`35708`	`session.indexInfo.closed = Date.now();`
`35712`	`35709`	`this.removeOldChains(session);`
`35713`	`35710`	`},`
Original file line number	Diff line number	Diff line change
`@@ -210,9 +210,6 @@ Internal.SessionRecord = function() {`
`210`	`210`	`};`
`211`	`211`	`}`
`212`	`212`	`}`
`213`		`- // Delete current root key and our ephemeral key pair to disallow ratchet stepping`
`214`		`- delete session.currentRatchet.rootKey;`
`215`		`- delete session.currentRatchet.ephemeralKeyPair;`
`216`	`213`	`session.indexInfo.closed = Date.now();`
`217`	`214`	`this.removeOldChains(session);`
`218`	`215`	`},`