refactor: fix lint errors

No change to logic. This fixes some lint errors. This is technically a
breaking change because we're dropping official support for node v4
(although the real breaking change will come after this when I update
shelljs).

For some reason the old eslint-wrapper wasn't actually reporting lint
errors (there were several on the main branch). I'm not going to debug
this since we can just delete the wrapper entirely.

Author: nfischer

.eslintrc.json

@@ -16,6 +16,8 @@
     "prefer-template": 0,
     "func-names": 0,
     "import/no-extraneous-dependencies": ["error", {"devDependencies": true}],
+    "import/order": 0,
+    "no-restricted-globals": 0,
     "new-cap": [2, {
       "capIsNewExceptions": [
         "ShellString"

.github/workflows/main.yml

@@ -10,7 +10,6 @@ jobs:
       fail-fast: false
       matrix:
         node-version:
-          - 4
           - 6
           - 8
           - 10

index.js

@@ -4,6 +4,7 @@ var plugin = require('shelljs/plugin');
 // Require whatever modules you need for your project
 var opener = require('opener');
 var fs = require('fs');
+
 var pathExistsSync = function (filePath) {
   try {
     fs.accessSync(filePath);
@@ -32,7 +33,7 @@ function open(options, fileName) {
 
 // Register the new plugin as a ShellJS command
 plugin.register('open', open, {
-  cmdOptions: {},   // There are no supported options for this command
+  cmdOptions: {}, // There are no supported options for this command
 });
 
 // Optionally, you can export the implementation of the command like so:

package.json

@@ -6,7 +6,7 @@
   "scripts": {
     "posttest": "npm run lint",
     "test": "mocha",
-    "lint": "node scripts/eslint-wrapper.js",
+    "lint": "eslint .",
     "changelog": "shelljs-changelog",
     "release:major": "shelljs-release major",
     "release:minor": "shelljs-release minor",
@@ -43,6 +43,6 @@
     "opener": "^1.4.1"
   },
   "engines": {
-    "node": ">=4"
+    "node": ">=6"
   }
 }

scripts/eslint-wrapper.js

@@ -27,7 +27,7 @@ var pluginOpen = require('..');
  * want to use ShellJS like this normally):
  */
 var shell = require('shelljs'); // recommended
-require('shelljs/global');      // not recommended
+require('shelljs/global'); //      not recommended
 
 /*
  * Now, require whichever other modules you want to require: