Remove Backend.connect callback overload

Author: Alec Gibson

lib/backend.js

@@ -101,11 +101,6 @@ Backend.prototype.close = function(callback) {
 };
 
 Backend.prototype.connect = function(connection, req, callback) {
-  if (typeof connection === 'function') {
-    callback = connection;
-    connection = undefined;
-  }
-
   var socket = new StreamSocket();
   if (connection) {
     connection.bindToSocket(socket);

test/client/connection.js

@@ -200,7 +200,7 @@ describe('client connection', function() {
 
   it('persists its id and seq when reconnecting', function(done) {
     var backend = this.backend;
-    backend.connect(function(connection) {
+    backend.connect(null, null, function(connection) {
       var id = connection.id;
       expect(id).to.be.ok;
       var doc = connection.get('test', '123');
@@ -218,7 +218,7 @@ describe('client connection', function() {
   });
 
   it('errors when submitting an op with a very large seq', function(done) {
-    this.backend.connect(function(connection) {
+    this.backend.connect(null, null, function(connection) {
       var doc = connection.get('test', '123');
       doc.create({foo: 'bar'}, function(error) {
         if (error) return done(error);

test/client/submit.js

@@ -355,7 +355,7 @@ module.exports = function() {
     });
 
     it('op submitted during inflight create does not compose and gets flushed', function(done) {
-      this.backend.connect(function(connection) {
+      this.backend.connect(null, null, function(connection) {
         var doc = connection.get('dogs', 'fido');
         doc.create({age: 3});
         // Submit an op after message is sent but before server has a chance to reply
@@ -802,8 +802,8 @@ module.exports = function() {
 
     it('snapshot fetch from query does not advance version of doc with pending ops', function(done) {
       var backend = this.backend;
-      backend.connect(function(connection1) {
-        backend.connect(function(connection2) {
+      backend.connect(null, null, function(connection1) {
+        backend.connect(null, null, function(connection2) {
           var doc = connection1.get('dogs', 'fido');
           var doc2 = connection2.get('dogs', 'fido');
           doc.create({name: 'kido'}, function(err) {