Skip to content

Commit dfb2caf

Browse files
justin808claude
andcommitted
Fix hardcoded Node version and restore yalc command consistency
Critical fixes: 1. Use translated node-version from matrix instead of hardcoded '20' - Latest config will now correctly use Node 22 instead of Node 20 2. Restore yalc command to match other workflows: 'cd packages/react-on-rails && yalc publish' 3. Re-enable conditional yarn cache (disabled for Node 22 due to V8 bug) This ensures the matrix actually controls which Node version is used. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 402b17b commit dfb2caf

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

.github/workflows/examples.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -116,11 +116,11 @@ jobs:
116116
- name: Setup Node
117117
uses: actions/setup-node@v4
118118
with:
119-
node-version: 20
120-
# TODO: Re-enable yarn caching once Node.js V8 cache crash is fixed
121-
# Tracking: https://github.com/actions/setup-node/issues/1028
122-
# cache: yarn
123-
# cache-dependency-path: '**/yarn.lock'
119+
node-version: ${{ steps.translate-matrix.outputs.node-version }}
120+
# Disable cache for Node 22 due to V8 bug in 22.21.0
121+
# https://github.com/nodejs/node/issues/56010
122+
cache: ${{ steps.translate-matrix.outputs.node-version != '22' && 'yarn' || '' }}
123+
cache-dependency-path: '**/yarn.lock'
124124
- name: Print system information
125125
run: |
126126
echo "Linux release: "; cat /etc/issue
@@ -145,7 +145,7 @@ jobs:
145145
yarn install --no-progress --no-emoji ${{ matrix.dependency-level == 'latest' && '--frozen-lockfile' || '' }}
146146
sudo yarn global add yalc
147147
- name: yalc publish for react-on-rails
148-
run: yarn yalc publish
148+
run: cd packages/react-on-rails && yalc publish
149149
- name: Install Ruby Gems for package
150150
run: |
151151
bundle lock --add-platform 'x86_64-linux'

0 commit comments

Comments
 (0)