Commit d1c9028
Fix test mocks to support stream.closed? checks
Commit 0815ce0 added stream.closed? checks to prevent wasted work after
client disconnect, but the test mocks didn't stub this method, causing
all streaming tests to fail with:
#<InstanceDouble(ActionController::Live::Buffer)> received unexpected
message :closed? with (no args)
Changes:
- Stub .closed? to return false in helper_spec.rb test setup
- Stub .closed? to return false in stream_spec.rb setup_stream_test
- Update spec/dummy/Gemfile.lock to include async gem dependencies
(needed when running bundle install in spec/dummy directory)
This fixes 14 failing tests:
- 10 failures in react_on_rails_pro_helper_spec.rb
- 4 failures in stream_spec.rb
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>1 parent 9b536a4 commit d1c9028
File tree
3 files changed
+20
-0
lines changed- react_on_rails_pro/spec
- dummy
- spec/helpers
- react_on_rails_pro
3 files changed
+20
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| 25 | + | |
25 | 26 | | |
26 | 27 | | |
27 | 28 | | |
| |||
107 | 108 | | |
108 | 109 | | |
109 | 110 | | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
110 | 117 | | |
111 | 118 | | |
112 | 119 | | |
| |||
131 | 138 | | |
132 | 139 | | |
133 | 140 | | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
134 | 145 | | |
135 | 146 | | |
136 | 147 | | |
| |||
165 | 176 | | |
166 | 177 | | |
167 | 178 | | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
168 | 182 | | |
169 | 183 | | |
170 | 184 | | |
| |||
184 | 198 | | |
185 | 199 | | |
186 | 200 | | |
| 201 | + | |
187 | 202 | | |
188 | 203 | | |
189 | 204 | | |
| |||
216 | 231 | | |
217 | 232 | | |
218 | 233 | | |
| 234 | + | |
219 | 235 | | |
220 | 236 | | |
221 | 237 | | |
| |||
447 | 463 | | |
448 | 464 | | |
449 | 465 | | |
| 466 | + | |
450 | 467 | | |
451 | 468 | | |
452 | 469 | | |
| |||
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
443 | 443 | | |
444 | 444 | | |
445 | 445 | | |
| 446 | + | |
446 | 447 | | |
447 | 448 | | |
448 | 449 | | |
| |||
583 | 584 | | |
584 | 585 | | |
585 | 586 | | |
| 587 | + | |
586 | 588 | | |
587 | 589 | | |
588 | 590 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
388 | 388 | | |
389 | 389 | | |
390 | 390 | | |
| 391 | + | |
391 | 392 | | |
392 | 393 | | |
393 | 394 | | |
| |||
0 commit comments