Skip to content

Commit 38377bc

Browse files
committed
Validate buffer size as Integer instead of Numeric
Change concurrent_component_streaming_buffer_size validation to require Integer instead of Numeric. Buffer sizes represent discrete queue capacity counts and should not accept float values like 64.5. This provides better type safety and clearer error messages for users who might accidentally pass non-integer values. Addresses CodeRabbit feedback.
1 parent de973fe commit 38377bc

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

react_on_rails_pro/lib/react_on_rails_pro/configuration.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -211,11 +211,11 @@ def validate_remote_bundle_cache_adapter
211211
end
212212

213213
def validate_concurrent_component_streaming_buffer_size
214-
return if concurrent_component_streaming_buffer_size.is_a?(Numeric) &&
214+
return if concurrent_component_streaming_buffer_size.is_a?(Integer) &&
215215
concurrent_component_streaming_buffer_size.positive?
216216

217217
raise ReactOnRailsPro::Error,
218-
"config.concurrent_component_streaming_buffer_size must be set and must be a positive number"
218+
"config.concurrent_component_streaming_buffer_size must be a positive integer"
219219
end
220220

221221
def setup_renderer_password

0 commit comments

Comments
 (0)