You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fix CI to always run full test suite on master branch (#2035)
## Summary
Fixes critical CI logic flaw where documentation-only commits on master
would skip all tests, allowing broken states to persist undetected.
## Problem
The `paths-ignore` directive was being applied to BOTH pull requests AND
master branch pushes, causing:
1. **Doc-only commits on master skip ALL CI tests** - If commit A has
failing tests, then commit B (doc-only) merges to master, the broken
state persists with no CI feedback
2. **Inconsistent test coverage** - Master should always run the full
test suite (both latest AND minimum dependency versions)
3. **Silent failures** - Test failures can be hidden by subsequent
documentation commits
## Solution
Remove `paths-ignore` from push events on master branch while keeping it
for pull requests:
```yaml
on:
push:
branches:
- 'master'
# Never skip on master - always run full test suite
pull_request:
paths-ignore:
- '**.md'
- 'docs/**'
```
This ensures:
- ✅ Master ALWAYS runs complete test suite (both latest AND minimum
deps)
- ✅ PRs can still skip irrelevant tests for faster feedback
- ✅ No more silent failures hidden by doc-only commits
## Files Changed
All main CI workflows updated:
- `integration-tests.yml`
- `gem-tests.yml`
- `lint-js-and-ruby.yml`
- `package-js-tests.yml`
- `pro-integration-tests.yml`
- `pro-lint.yml`
- `pro-test-package-and-gem.yml`
- `examples.yml`
- `playwright.yml`
## Test Plan
- Verified workflow syntax with `actionlint`
- Confirmed linting passes locally
- CI will validate on this PR
Generated with [Claude Code](https://claude.com/claude-code)
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
## Chores
* Ensured master branch pushes always run the full CI/test suite by
removing path-based skip rules that previously excluded docs and other
file types; pull request trigger behavior remains unchanged.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
0 commit comments