Skip to content

Commit 29336f1

Browse files
authored
Fix CI to always run full test suite on master branch (#2035)
## Summary Fixes critical CI logic flaw where documentation-only commits on master would skip all tests, allowing broken states to persist undetected. ## Problem The `paths-ignore` directive was being applied to BOTH pull requests AND master branch pushes, causing: 1. **Doc-only commits on master skip ALL CI tests** - If commit A has failing tests, then commit B (doc-only) merges to master, the broken state persists with no CI feedback 2. **Inconsistent test coverage** - Master should always run the full test suite (both latest AND minimum dependency versions) 3. **Silent failures** - Test failures can be hidden by subsequent documentation commits ## Solution Remove `paths-ignore` from push events on master branch while keeping it for pull requests: ```yaml on: push: branches: - 'master' # Never skip on master - always run full test suite pull_request: paths-ignore: - '**.md' - 'docs/**' ``` This ensures: - ✅ Master ALWAYS runs complete test suite (both latest AND minimum deps) - ✅ PRs can still skip irrelevant tests for faster feedback - ✅ No more silent failures hidden by doc-only commits ## Files Changed All main CI workflows updated: - `integration-tests.yml` - `gem-tests.yml` - `lint-js-and-ruby.yml` - `package-js-tests.yml` - `pro-integration-tests.yml` - `pro-lint.yml` - `pro-test-package-and-gem.yml` - `examples.yml` - `playwright.yml` ## Test Plan - Verified workflow syntax with `actionlint` - Confirmed linting passes locally - CI will validate on this PR Generated with [Claude Code](https://claude.com/claude-code) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Chores * Ensured master branch pushes always run the full CI/test suite by removing path-based skip rules that previously excluded docs and other file types; pull request trigger behavior remains unchanged. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
1 parent 240012f commit 29336f1

File tree

9 files changed

+9
-43
lines changed

9 files changed

+9
-43
lines changed

.github/workflows/examples.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,7 @@ on:
44
push:
55
branches:
66
- 'master'
7-
paths-ignore:
8-
- '**.md'
9-
- 'docs/**'
7+
# Never skip on master - always run full test suite
108
pull_request:
119
paths-ignore:
1210
- '**.md'

.github/workflows/gem-tests.yml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,7 @@ on:
44
push:
55
branches:
66
- 'master'
7-
paths-ignore:
8-
- '**.md'
9-
- 'docs/**'
10-
- 'packages/**'
11-
- 'react_on_rails_pro/**'
7+
# Never skip on master - always run full test suite
128
pull_request:
139
paths-ignore:
1410
- '**.md'

.github/workflows/integration-tests.yml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,7 @@ on:
44
push:
55
branches:
66
- 'master'
7-
paths-ignore:
8-
- '**.md'
9-
- 'docs/**'
10-
- 'react_on_rails_pro/**'
7+
# Never skip on master - always run full test suite
118
pull_request:
129
paths-ignore:
1310
- '**.md'

.github/workflows/lint-js-and-ruby.yml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,7 @@ on:
44
push:
55
branches:
66
- 'master'
7-
paths-ignore:
8-
- '**.md'
9-
- 'docs/**'
10-
- 'react_on_rails_pro/**'
7+
# Never skip on master - always run full test suite
118
pull_request:
129
paths-ignore:
1310
- '**.md'

.github/workflows/package-js-tests.yml

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,7 @@ on:
44
push:
55
branches:
66
- 'master'
7-
paths-ignore:
8-
- '**.md'
9-
- 'docs/**'
10-
- 'lib/**'
11-
- 'spec/react_on_rails/**'
12-
- 'react_on_rails_pro/**'
7+
# Never skip on master - always run full test suite
138
pull_request:
149
paths-ignore:
1510
- '**.md'

.github/workflows/playwright.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,7 @@ name: Playwright E2E Tests
33
on:
44
push:
55
branches: [master]
6-
paths-ignore:
7-
- '**.md'
8-
- 'docs/**'
6+
# Never skip on master - always run full test suite
97
workflow_dispatch:
108

119
jobs:

.github/workflows/pro-integration-tests.yml

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,7 @@ on:
44
push:
55
branches:
66
- 'master'
7-
paths-ignore:
8-
- '**.md'
9-
- 'docs/**'
10-
- 'lib/**'
11-
- 'spec/**'
12-
- 'packages/react_on_rails/**'
7+
# Never skip on master - always run full test suite
138
pull_request:
149
paths-ignore:
1510
- '**.md'

.github/workflows/pro-lint.yml

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,7 @@ on:
44
push:
55
branches:
66
- 'master'
7-
paths-ignore:
8-
- '**.md'
9-
- 'docs/**'
10-
- 'lib/**'
11-
- 'spec/**'
12-
- 'packages/react_on_rails/**'
7+
# Never skip on master - always run full test suite
138
pull_request:
149
paths-ignore:
1510
- '**.md'

.github/workflows/pro-test-package-and-gem.yml

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,7 @@ on:
44
push:
55
branches:
66
- 'master'
7-
paths-ignore:
8-
- '**.md'
9-
- 'docs/**'
10-
- 'lib/**'
11-
- 'spec/**'
12-
- 'packages/react_on_rails/**'
7+
# Never skip on master - always run full test suite
138
pull_request:
149
paths-ignore:
1510
- '**.md'

0 commit comments

Comments
 (0)