Fix CI issues: Ruby version consistency, lint integration, and optimizations

- Update Rails 6.1 CI job to use Ruby 3.0.6 (consistent with gemspec requirement)
- Add lint checks to all CI jobs in main workflow
- Fix pre-commit hook to use bash instead of sh for better compatibility
- Optimize file globbing in rake tasks for better performance
- Use more efficient reject/select pattern instead of multiple next statements

Author: justin808

.github/workflows/ruby.yml

@@ -15,10 +15,12 @@ jobs:
     - name: Set up Ruby
       uses: ruby/setup-ruby@v1
       with:
-        ruby-version: 2.7.6
+        ruby-version: 3.0.6
         bundler-cache: true
     - name: Run tests
       run: bundle exec rake
+    - name: Run lint checks
+      run: bundle exec rake lint
     - name: Run interaction tests
       run: ./specs_e2e/rails_6_1/test.sh
       env:
@@ -36,6 +38,8 @@ jobs:
         bundler-cache: true
     - name: Run tests
       run: bundle exec rake
+    - name: Run lint checks
+      run: bundle exec rake lint
     - run: gem uninstall -v '>= 2' -ax bundler || true
     - run: gem install bundler -v '< 2'
     - name: Run interaction tests
@@ -55,6 +59,8 @@ jobs:
         bundler-cache: true
     - name: Run tests
       run: bundle exec rake
+    - name: Run lint checks
+      run: bundle exec rake lint
     - run: gem uninstall -v '>= 2' -ax bundler || true
     - run: gem install bundler -v '< 2'
     - name: Run interaction tests

bin/install-hooks

@@ -8,7 +8,7 @@ pre_commit_hook = File.join(hooks_dir, 'pre-commit')
 
 # Create pre-commit hook content
 hook_content = <<~HOOK
-  #!/bin/sh
+  #!/usr/bin/env bash
   # Pre-commit hook to run linters and check for newlines
 
   # Check for files missing newlines

rakelib/lint.rake

@@ -20,11 +20,14 @@ desc 'Ensure all files end with newline'
 task :check_newlines do
   files_without_newline = []
 
-  Dir.glob('**/*.{rb,rake,yml,yaml,md,gemspec,ru,erb,js,json}').each do |file|
-    next if file.include?('vendor/') || file.include?('node_modules/') || file.include?('.git/')
-    next if file.include?('pkg/') || file.include?('tmp/') || file.include?('coverage/')
-    next unless File.file?(file)
+  # Define excluded directories
+  excluded_dirs = %w[vendor/ node_modules/ .git/ pkg/ tmp/ coverage/]
 
+  # Get all relevant files and filter out excluded directories more efficiently
+  Dir.glob('**/*.{rb,rake,yml,yaml,md,gemspec,ru,erb,js,json}')
+     .reject { |f| excluded_dirs.any? { |dir| f.start_with?(dir) } }
+     .select { |f| File.file?(f) }
+     .each do |file|
     content = File.read(file)
     files_without_newline << file unless content.empty? || content.end_with?("\n")
   end
@@ -42,11 +45,14 @@ desc 'Fix files missing final newline'
 task :fix_newlines do
   fixed_files = []
 
-  Dir.glob('**/*.{rb,rake,yml,yaml,md,gemspec,ru,erb,js,json}').each do |file|
-    next if file.include?('vendor/') || file.include?('node_modules/') || file.include?('.git/')
-    next if file.include?('pkg/') || file.include?('tmp/') || file.include?('coverage/')
-    next unless File.file?(file)
+  # Define excluded directories (same as check_newlines)
+  excluded_dirs = %w[vendor/ node_modules/ .git/ pkg/ tmp/ coverage/]
 
+  # Get all relevant files and filter out excluded directories more efficiently
+  Dir.glob('**/*.{rb,rake,yml,yaml,md,gemspec,ru,erb,js,json}')
+     .reject { |f| excluded_dirs.any? { |dir| f.start_with?(dir) } }
+     .select { |f| File.file?(f) }
+     .each do |file|
     content = File.read(file)
     unless content.empty? || content.end_with?("\n")
       File.write(file, content + "\n")