refactor: streamline output messages in ApiVersionsCommand and update error response structure in tests

Author: shahghasiadil

src/Console/Commands/ApiVersionsCommand.php

@@ -90,7 +90,7 @@ public function handle(): int
             if ($this->option('json')) {
                 $this->line(json_encode(['routes' => [], 'supported_versions' => $this->versionManager->getSupportedVersions()], JSON_PRETTY_PRINT));
             } else {
-                $this->components->info('No matching routes found.');
+                $this->info('No matching routes found.');
             }
 
             return self::SUCCESS;
@@ -120,8 +120,8 @@ public function handle(): int
         $this->table($headers, $rows);
 
         $this->newLine();
-        $this->components->info('Supported API Versions: '.implode(', ', $this->versionManager->getSupportedVersions()));
-        $this->components->info('Total Routes: '.count($rows));
+        $this->info('Supported API Versions: '.implode(', ', $this->versionManager->getSupportedVersions()));
+        $this->info('Total Routes: '.count($rows));
 
         return self::SUCCESS;
     }

tests/Feature/AttributeVersioningTest.php

@@ -59,7 +59,8 @@
 
     $response->assertStatus(400)
         ->assertJson([
-            'error' => 'Unsupported API Version',
+            'title' => 'Unsupported API Version',
+            'status' => 400,
         ]);
 });
 

tests/Unit/AttributeApiVersionMiddlewareTest.php

@@ -178,8 +178,9 @@
         expect($result->getStatusCode())->toBe(400);
 
         $data = $result->getData(true);
-        expect($data['error'])->toBe('Unsupported API Version');
-        expect($data['message'])->toBe("API version '3.0' is not supported for this endpoint.");
+        expect($data['title'])->toBe('Unsupported API Version');
+        expect($data['detail'])->toBe("API version '3.0' is not supported for this endpoint.");
+        expect($data['status'])->toBe(400);
         expect($data['requested_version'])->toBe('3.0');
         expect($data['supported_versions'])->toBe(['1.0', '2.0', '2.1']);
         expect($data['endpoint_versions'])->toBe(['1.0', '2.0']);
@@ -211,8 +212,9 @@
         expect($result->getStatusCode())->toBe(400);
 
         $data = $result->getData(true);
-        expect($data['error'])->toBe('Unsupported API Version');
-        expect($data['message'])->toBe("API version '4.0' is not supported.");
+        expect($data['title'])->toBe('Unsupported API Version');
+        expect($data['detail'])->toBe("API version '4.0' is not supported for this endpoint.");
+        expect($data['status'])->toBe(400);
         expect($data['requested_version'])->toBe('4.0');
         expect($data['supported_versions'])->toBe(['1.0', '2.0']);
     });
@@ -226,18 +228,15 @@
             ->once()
             ->andReturn('2.0');
 
-        $this->versionManager->shouldReceive('getSupportedVersions')
-            ->once()
-            ->andReturn(['1.0', '2.0']);
-
         $result = $this->middleware->handle($request, fn () => new Response);
 
         expect($result)->toBeInstanceOf(JsonResponse::class);
-        expect($result->getStatusCode())->toBe(400);
+        expect($result->getStatusCode())->toBe(404);
 
         $data = $result->getData(true);
-        expect($data['error'])->toBe('Unsupported API Version');
-        expect($data['message'])->toBe('Route not found');
+        expect($data['title'])->toBe('Route Not Found');
+        expect($data['detail'])->toBe('Route not found');
+        expect($data['status'])->toBe(404);
     });
 });
 

tests/Unit/AttributeVersionResolverTest.php

@@ -3,6 +3,7 @@
 use Illuminate\Routing\Route;
 use ShahGhasiAdil\LaravelApiVersioning\Examples\SharedController;
 use ShahGhasiAdil\LaravelApiVersioning\Examples\V1UserController;
+use ShahGhasiAdil\LaravelApiVersioning\Services\AttributeCacheService;
 use ShahGhasiAdil\LaravelApiVersioning\Services\AttributeVersionResolver;
 use ShahGhasiAdil\LaravelApiVersioning\Services\VersionManager;
 
@@ -19,7 +20,8 @@
     ];
 
     $this->versionManager = new VersionManager($config);
-    $this->resolver = new AttributeVersionResolver($this->versionManager);
+    $this->cache = new AttributeCacheService(enabled: false, ttl: 3600); // Disable cache for tests
+    $this->resolver = new AttributeVersionResolver($this->versionManager, $this->cache);
 });
 
 test('resolves version from controller attribute', function () {