-
Notifications
You must be signed in to change notification settings - Fork 23
Open
Description
- The community page links to
https://github.com/shader-slang/slang/tree/master/docs/proposalswhich does not exist anymore, it's been moved tohttps://github.com/shader-slang/spec/tree/master/proposals CODEOWNERthings haven't exactly panned out as described, instead, the file is just* @shader-slang/dev(the group owns everything, nobody has individualized directories)- As a consequence, this bit isn't exactly true either:
A pull request is approved only when at least two owners of each directory affected by the changes have given their approval.PRs are far more often approved by only one person than multiple before they get merged.
- As a consequence, this bit isn't exactly true either:
- Saying
Pull requests are expected to be reviewed by the committers within 24 hours after they are created or updated, and to close within a week.is pretty optimistic and seems to not have been met for most PRs for a while (at least of those opened by non-NV folks who are most likely to form expectations based on this community page). It would probably be safer to expect a review in a week and close in a month.- Just wanted to clarify that I don't personally feel like longer wait times are an issue; this is more about setting realistic or even pessimistic expectations to avoid potential frustrations for new contributors
- Also, small PRs are more likely to get quick reviews than large ones. While this is probably obvious to most, it might still be worth mentioning on the page as well.
Metadata
Metadata
Assignees
Labels
No labels