find destination plugin by name (#86)

* add find destination plugin by name

* update parameter name

Author: wenxi-zeng

core/src/main/java/com/segment/analytics/kotlin/core/Analytics.kt

@@ -1,5 +1,6 @@
 package com.segment.analytics.kotlin.core
 
+import com.segment.analytics.kotlin.core.platform.DestinationPlugin
 import com.segment.analytics.kotlin.core.platform.EventPlugin
 import com.segment.analytics.kotlin.core.platform.Plugin
 import com.segment.analytics.kotlin.core.platform.Timeline
@@ -405,6 +406,12 @@ open class Analytics protected constructor(
      */
     fun <T: Plugin> find(plugin: KClass<T>): T? = this.timeline.find(plugin)
 
+    /**
+     * Retrieve the first match of registered destination plugin by key. It finds
+     * @param destinationKey [String]
+     */
+    fun find(destinationKey: String): DestinationPlugin? = this.timeline.find(destinationKey)
+
     /**
      * Retrieve the first match of registered plugin. It finds
      *      1. all instances of the given class/interface

core/src/main/java/com/segment/analytics/kotlin/core/compat/JavaAnalytics.kt

@@ -7,6 +7,7 @@ import com.segment.analytics.kotlin.core.Properties
 import com.segment.analytics.kotlin.core.Storage
 import com.segment.analytics.kotlin.core.Traits
 import com.segment.analytics.kotlin.core.emptyJsonObject
+import com.segment.analytics.kotlin.core.platform.DestinationPlugin
 import com.segment.analytics.kotlin.core.platform.Plugin
 import kotlinx.coroutines.CoroutineScope
 import kotlinx.serialization.json.JsonObject
@@ -200,6 +201,20 @@ class JavaAnalytics private constructor() {
      */
     fun <T: Plugin> find(plugin: Class<T>) = analytics.find(plugin.kotlin)
 
+    /**
+     * Retrieve the first match of registered destination plugin by name. It finds
+     * @param destination [String]
+     */
+    fun find(destinationKey: String): DestinationPlugin? = analytics.find(destinationKey)
+
+    /**
+     * Retrieve the first match of registered plugin. It finds
+     *      1. all instances of the given class/interface
+     *      2. and all instances of subclass of the given class/interface
+     * @param plugin [Class]
+     */
+    fun <T: Plugin> findAll(plugin: Class<T>): List<T> = analytics.findAll(plugin.kotlin)
+
     /**
      * Remove a plugin from the analytics timeline using its name
      * @param plugin [Plugin] to be remove

core/src/main/java/com/segment/analytics/kotlin/core/platform/Timeline.kt

@@ -91,6 +91,13 @@ internal class Timeline {
         return null
     }
 
+    // Find a destination plugin by its name
+    fun find(destination: String) =
+        plugins[Plugin.Type.Destination]?.plugins?.find {
+            it is DestinationPlugin && it.key == destination
+        } as? DestinationPlugin
+
+
     fun <T: Plugin> findAll(pluginClass: KClass<T>): List<T> {
         val result = mutableListOf<T>()
         plugins.forEach { (_, list) ->

core/src/test/kotlin/com/segment/analytics/kotlin/core/AnalyticsTests.kt

@@ -1,5 +1,6 @@
 package com.segment.analytics.kotlin.core
 
+import com.segment.analytics.kotlin.core.platform.DestinationPlugin
 import com.segment.analytics.kotlin.core.platform.Plugin
 import com.segment.analytics.kotlin.core.platform.plugins.ContextPlugin
 import com.segment.analytics.kotlin.core.utils.*
@@ -428,6 +429,19 @@ class AnalyticsTests {
                 assertTrue(plugins.contains(parent))
                 assertTrue(plugins.contains(child))
             }
+
+            @Test
+            fun `find() finds destination plugin by name`() {
+                val dest = "testPlugin"
+                val expected = object: DestinationPlugin() {
+                    override val key = dest
+                }
+                analytics.add(expected)
+
+                val actual = analytics.find(dest)
+
+                assertEquals(expected, actual)
+            }
         }
     }