Problem with benchmarks

[joeldrapper]

Hey, I love what you’re doing here. I’ve been working on something pretty similar for a while now. Love writing views in Ruby!

I feel really bad for pointing this out, but the benchmarks here spend a significant amount of time generating random data, it’s only possible for them to show a few percentage points of difference because of this.

It might make sense to generate this random data once and assign it to a constant so it doesn’t impact the results.

https://github.com/sebyx07/ruby2html/blob/main/app/controllers/benchmark_controller.rb#L17

[sebyx07]

ruby 3.3.4 (2024-07-09 revision be1089c8ec) +YJIT [x86_64-linux]
Warming up --------------------------------------
GET /benchmark/html (ERB)
                        40.000 i/100ms
GET /benchmark/ruby (Ruby2html templates .html.rb)
                        12.000 i/100ms
GET /benchmark/ruby (Ruby2html + view components)
                        12.000 i/100ms
GET /benchmark/slim (Slim)
                        46.000 i/100ms
GET /benchmark/phlex (Phlex)
                        34.000 i/100ms
Calculating -------------------------------------
GET /benchmark/html (ERB)
                        414.030 (± 2.4%) i/s -     24.840k in  60.032818s
GET /benchmark/ruby (Ruby2html templates .html.rb)
                        124.973 (± 3.2%) i/s -      7.500k in  60.071485s
GET /benchmark/ruby (Ruby2html + view components)
                        123.211 (± 4.1%) i/s -      7.380k in  60.000731s
GET /benchmark/slim (Slim)
                        431.525 (± 9.0%) i/s -     25.668k in  60.103492s
GET /benchmark/phlex (Phlex)
                        328.925 (± 7.0%) i/s -     19.618k in  60.019961s

Comparison:
GET /benchmark/slim (Slim):      431.5 i/s
GET /benchmark/html (ERB):      414.0 i/s - same-ish: difference falls within error
GET /benchmark/phlex (Phlex):      328.9 i/s - 1.31x  slower
GET /benchmark/ruby (Ruby2html templates .html.rb):      125.0 i/s - 3.45x  slower
GET /benchmark/ruby (Ruby2html + view components):      123.2 i/s - 3.50x  slower

[sebyx07]

my implementation might be slower due to using StringIO to build the tags and maybe the railtie?

https://github.com/sebyx07/ruby2html/blob/main/lib/gem/ruby2html/railtie.rb

[joeldrapper]

We tested StringIO and it was a little slower, but that was years ago. It might be faster now. Phlex has had quite a few performance optimisations over time. The attribute cache plays a significant role but there are also a lot of fast paths taken when rendering elements. It also uses code generation quite a lot. It’s all at the expense of readability, though. There are so many different case statements and conditionals trying to optimise for the fastest path through depending on various factors.

[sebyx07]

I wanted to build smth simple - top performance wasn't a priority. if the future after I release rails super components, I can make it as a C/Java ext

[sebyx07]

right now it's just 150L file https://github.com/sebyx07/ruby2html/blob/main/lib/gem/ruby2html/render.rb

[sebyx07]

renderer = Ruby2html::Render.new(nil) do
  html do
    head do
      title 'Ruby2html Example'
    end
    body do
      h1 'Hello, World!'
    end
  end
end

this was the first objective