Fix a crash when unsupported graphic effects are used

adazem009 · adazem009 · commit a827573fcf00 · 2024-09-29T10:23:42.000+02:00
diff --git a/src/scratch/target.cpp b/src/scratch/target.cpp
@@ -540,6 +540,9 @@ bool Target::touchingColor(const Value &color, const Value &mask) const
 /*! Returns the value of the given graphics effect. */
 double Target::graphicsEffectValue(IGraphicsEffect *effect) const
 {
+    if (!effect)
+        return 0;
+
     auto it = impl->graphicsEffects.find(effect);
 
     if (it == impl->graphicsEffects.cend())
@@ -551,8 +554,8 @@ double Target::graphicsEffectValue(IGraphicsEffect *effect) const
 /*! Sets the value of the given graphics effect. */
 void Target::setGraphicsEffectValue(IGraphicsEffect *effect, double value)
 {
-    assert(effect);
-    impl->graphicsEffects[effect] = effect->clamp(value);
+    if (effect)
+        impl->graphicsEffects[effect] = effect->clamp(value);
 }
 
 /*! Sets the value of all graphics effects to 0 (clears them). */

Original file line number	Diff line number	Diff line change
`@@ -540,6 +540,9 @@ bool Target::touchingColor(const Value &color, const Value &mask) const`
`540`	`540`	`/! Returns the value of the given graphics effect. /`
`541`	`541`	`double Target::graphicsEffectValue(IGraphicsEffect *effect) const`
`542`	`542`	`{`
	`543`	`+ if (!effect)`
	`544`	`+ return 0;`
	`545`	`+`
`543`	`546`	`auto it = impl->graphicsEffects.find(effect);`
`544`	`547`
`545`	`548`	`if (it == impl->graphicsEffects.cend())`
`@@ -551,8 +554,8 @@ double Target::graphicsEffectValue(IGraphicsEffect *effect) const`
`551`	`554`	`/! Sets the value of the given graphics effect. /`
`552`	`555`	`void Target::setGraphicsEffectValue(IGraphicsEffect *effect, double value)`
`553`	`556`	`{`
`554`		`- assert(effect);`
`555`		`- impl->graphicsEffects[effect] = effect->clamp(value);`
	`557`	`+ if (effect)`
	`558`	`+ impl->graphicsEffects[effect] = effect->clamp(value);`
`556`	`559`	`}`
`557`	`560`
`558`	`561`	`/! Sets the value of all graphics effects to 0 (clears them). /`