fix(_comp_last_index): use ${arr[*]: -1} to get the last element

akinomyoga · akinomyoga · commit 76ee1c225ddd · 2024-05-13T12:52:47.000+09:00
diff --git a/completions/ARRAY b/completions/ARRAY
@@ -166,9 +166,8 @@ _comp_uniq()
 _comp_last_index()
 {
     local -n _comp_last_index__array=$1 _comp_last_index__ret=$2
-    local -i _comp_last_index__i
-    for _comp_last_index__i in "${!_comp_last_index__array[@]}"; do :; done
-    _comp_last_index__ret=$_comp_last_index__i
+    local -a _comp_last_index__indices=("${!_comp_last_index__array[@]}")
+    _comp_last_index__ret=${_comp_last_index__indices[*]: -1}
 }
 
 _comp_compact()

Original file line number	Diff line number	Diff line change
`@@ -166,9 +166,8 @@ _comp_uniq()`
`166`	`166`	`_comp_last_index()`
`167`	`167`	`{`
`168`	`168`	`local -n _comp_last_index__array=$1 _comp_last_index__ret=$2`
`169`		`- local -i _comp_last_index__i`
`170`		`- for _comp_last_index__i in "${!_comp_last_index__array[@]}"; do :; done`
`171`		`- _comp_last_index__ret=$_comp_last_index__i`
	`169`	`+ local -a _comp_last_index__indices=("${!_comp_last_index__array[@]}")`
	`170`	`+ _comp_last_index__ret=${_comp_last_index__indices[*]: -1}`
`172`	`171`	`}`
`173`	`172`
`174`	`173`	`_comp_compact()`