Skip to content

Commit dec05b8

Browse files
committed
Fixing SPEC from comments
1 parent fb32d6b commit dec05b8

File tree

1 file changed

+17
-6
lines changed

1 file changed

+17
-6
lines changed

rpm/scitokens-cpp.spec

Lines changed: 17 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,21 @@
11
Name: scitokens-cpp
22
Version: 0.3.3
3-
Release: 1%{?dist}
3+
Release: 2%{?dist}
44
Summary: C++ Implementation of the SciTokens Library
55
License: Apache 2.0
66
URL: https://github.com/scitokens/scitokens-cpp
77

88
# Generated from:
9-
# git_archive_all.py --prefix=scitokens-cpp-0.3.2/ --force-submodules -9 scitokens-cpp-0.3.2.tar.gz
10-
# Where git_archive_all.py is from https://github.com/Kentzo/git-archive-all.git
11-
Source0: %{name}-%{version}.tar.gz
9+
# git archive --prefix "scitokens-cpp-0.3.3/" -o "scitokens-cpp-0.3.3.tar" v0.3.3
10+
# git submodule update --init
11+
# git submodule foreach --recursive "git archive --prefix=scitokens-cpp-0.3.3/\$path/ --output=\$sha1.tar HEAD && tar --concatenate --file=$(pwd)/scitokens-cpp-0.3.3.tar \$sha1.tar && rm \$sha1.tar"
12+
# gzip "scitokens-cpp-0.3.3.tar"
13+
Source0: https://github.com/scitokens/%{name}/archive/%{name}-%{version}.tar.gz
14+
15+
# Scitokens-cpp bundles jwt-cpp, a header only dependency
16+
# Since it doesn't create a library that can be used by others, it seems
17+
# inappropriate to include a "Provides", as jwt-cpp is not provided
18+
# by this package.
1219

1320
BuildRequires: gcc-c++
1421
BuildRequires: cmake
@@ -43,7 +50,7 @@ do_build () {
4350
mkdir build
4451
cd build
4552
%cmake ..
46-
make
53+
%make_build
4754
}
4855
export -f do_build
4956
%if 0%{?el6}
@@ -54,7 +61,7 @@ do_build
5461

5562
%install
5663
pushd build
57-
make install DESTDIR=$RPM_BUILD_ROOT
64+
%make_build install DESTDIR=$RPM_BUILD_ROOT
5865
popd
5966

6067
%post
@@ -72,6 +79,10 @@ popd
7279
%defattr(-,root,root,-)
7380

7481
%changelog
82+
* Tue Jul 30 2019 Derek Weitzel <dweitzel@unl.edu> - 0.3.3-2
83+
- Change the Source URL
84+
- Use make_build in the packaging
85+
7586
* Thu Jul 25 2019 Derek Weitzel <dweitzel@unl.edu> - 0.3.3-1
7687
- Merge OSG changes
7788
- Use a newer, still supported version of devtoolset

0 commit comments

Comments
 (0)