Remove extranous catch for bad cast, as that's now handled by checking types.

djw8605 · djw8605 · commit af41322ec089 · 2025-08-12T20:50:28.000Z
diff --git a/src/scitokens.cpp b/src/scitokens.cpp
@@ -251,11 +251,6 @@ int scitoken_get_expiration(const SciToken token, long long *expiry,
             }
             return -1;
         }
-    } catch (std::bad_cast &exc) {
-        if (err_msg) {
-            *err_msg = strdup("'exp' claim has invalid format - expected a number (integer or float)");
-        }
-        return -1;
     } catch (std::exception &exc) {
         if (err_msg) {
             *err_msg = strdup(exc.what());

Original file line number	Diff line number	Diff line change
`@@ -251,11 +251,6 @@ int scitoken_get_expiration(const SciToken token, long long *expiry,`
`251`	`251`	`}`
`252`	`252`	`return -1;`
`253`	`253`	`}`
`254`		`- } catch (std::bad_cast &exc) {`
`255`		`- if (err_msg) {`
`256`		`- *err_msg = strdup("'exp' claim has invalid format - expected a number (integer or float)");`
`257`		`- }`
`258`		`- return -1;`
`259`	`254`	`} catch (std::exception &exc) {`
`260`	`255`	`if (err_msg) {`
`261`	`256`	`*err_msg = strdup(exc.what());`