Skip to content

Commit 3001212

Browse files
committed
Do not pass polymorphic exceptions by value.
1 parent c58da33 commit 3001212

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/scitokens.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,7 @@ int validator_validate(Validator validator, SciToken scitoken, char **err_msg) {
216216

217217
try {
218218
real_validator->verify(*real_scitoken);
219-
} catch (std::exception exc) {
219+
} catch (std::exception &exc) {
220220
if (err_msg) {*err_msg = strdup(exc.what());}
221221
return -1;
222222
}

src/scitokens_internal.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -384,7 +384,7 @@ class Enforcer {
384384
try {
385385
m_validator.verify(scitoken);
386386
return true;
387-
} catch (std::runtime_error) {
387+
} catch (std::runtime_error &) {
388388
return false;
389389
}
390390
}

0 commit comments

Comments
 (0)