DataHandle: Use persistent buffer for conversions.

- this avoids allocating a new byte array for each read

Author: gab1one

src/main/java/org/scijava/io/handle/AbstractDataHandle.java

@@ -44,6 +44,13 @@ public abstract class AbstractDataHandle<L extends Location> extends
 	AbstractWrapperPlugin<L> implements DataHandle<L>
 {
 
+	private byte[] conversionBuffer = new byte[8];
+	
+	@Override
+	public byte[] conversionBuffer() {
+		return conversionBuffer;
+	}
+ 
 	// -- Fields --
 
 	private ByteOrder order = ByteOrder.BIG_ENDIAN;

src/main/java/org/scijava/io/handle/DataHandle.java

@@ -250,6 +250,11 @@ default void setLittleEndian(final boolean little) {
 	/** Sets the native encoding of the stream. */
 	void setEncoding(String encoding);
 
+	/**
+	 * @return a 8 byte long buffer array used for type conversions
+	 */
+	byte[] conversionBuffer();
+
 	/** Reads a string of arbitrary length, terminated by a null char. */
 	default String readCString() throws IOException {
 		final String line = findString("\0");
@@ -515,7 +520,7 @@ default int readUnsignedByte() throws IOException {
 
 	@Override
 	default short readShort() throws IOException {
-		final byte[] buf = new byte[2];
+		final byte[] buf = conversionBuffer();
 		final int read = read(buf, 0, 2);
 		if (read < 2) throw new EOFException();
 		return Bytes.toShort(buf, isLittleEndian());
@@ -533,17 +538,17 @@ default char readChar() throws IOException {
 
 	@Override
 	default int readInt() throws IOException {
-		final byte[] buf = new byte[4];
+		final byte[] buf = conversionBuffer();
 		final int read = read(buf, 0, 4);
 		if (read < 4) throw new EOFException();
 		return Bytes.toInt(buf, isLittleEndian());
 	}
 
 	@Override
 	default long readLong() throws IOException {
-		byte[] buf = new byte[8];
-		int read = read(buf, 0, 8);
-		if (read < 0) {
+		final byte[] buf = conversionBuffer();
+		final int read = read(buf, 0, 8);
+		if (read < 8) {
 			throw new EOFException();
 		}
 		return Bytes.toLong(buf, isLittleEndian());
@@ -614,32 +619,42 @@ default void writeByte(final int v) throws IOException {
 
 	@Override
 	default void writeShort(final int v) throws IOException {
-		write(Bytes.fromShort((short) v, isLittleEndian()));
+		final byte[] buf = conversionBuffer();
+		Bytes.unpack(v, buf, 0, 2, isLittleEndian());
+		write(buf, 0, 2);
 	}
 
 	@Override
 	default void writeChar(final int v) throws IOException {
-		write(Bytes.fromShort((short) v, isLittleEndian()));
+		writeShort(v);
 	}
 
 	@Override
 	default void writeInt(final int v) throws IOException {
-		write(Bytes.fromInt(v, isLittleEndian()));
+		final byte[] buf = conversionBuffer();
+		Bytes.unpack(v, buf, 0, 4, isLittleEndian());
+		write(buf, 0, 4);
 	}
 
 	@Override
 	default void writeLong(final long v) throws IOException {
-		write(Bytes.fromLong(v, isLittleEndian()));
+		final byte[] buf = conversionBuffer();
+		Bytes.unpack(v, buf, 0, 8, isLittleEndian());
+		write(buf, 0, 8);
 	}
 
 	@Override
 	default void writeFloat(final float v) throws IOException {
-		write(Bytes.fromFloat(v, isLittleEndian()));
+		final byte[] buf = conversionBuffer();
+		Bytes.unpack(Float.floatToIntBits(v), buf, 0, 4, isLittleEndian());
+		write(buf, 0, 4);
 	}
 
 	@Override
 	default void writeDouble(final double v) throws IOException {
-		write(Bytes.fromDouble(v, isLittleEndian()));
+		final byte[] buf = conversionBuffer();
+		Bytes.unpack(Double.doubleToLongBits(v), buf, 0, 8, isLittleEndian());
+		write(buf, 0, 8);
 	}
 
 	@Override