chore: enable ALL for ruff (#294)

* chore: enable ALL for ruff

Signed-off-by: Henry Schreiner <henryfs@princeton.edu>

* style: pre-commit fixes

* Update src/repo_review/checks.py

* fix: FBT and click not compatible

Signed-off-by: Henry Schreiner <henryfs@princeton.edu>

---------

Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Author: henryiii

pyproject.toml

@@ -210,50 +210,21 @@ show-fixes = true
 
 
 [tool.ruff.lint]
-extend-select = [
-  "ARG",         # flake8-unused-arguments
-  "B",           # flake8-bugbear
-  "BLE",         # flake8-blind-except
-  "C4",          # flake8-comprehensions
-  "DTZ",         # flake8-datetimez
-  "EM",          # flake8-errmsg
-  "EXE",         # flake8-executable
-  "FA",          # flake8-future-annotations
-  "FLY",         # flynt
-  "FURB",        # refurb
-  "G",           # flake8-logging-format
-  "I",           # isort
-  "ICN",         # flake8-import-conventions
-  "ISC",         # flake8-implicit-str-concat
-  "LOG",         # flake8-logging
-  "PERF",        # Perflint
-  "PGH",         # pygrep-hooks
-  "PIE",         # flake8-pie
-  "PL",          # pylint
-  "PT",          # flake8-pytest-style
-  "PTH",         # flake8-use-pathlib
-  "PYI",         # flake8-pyi
-  "Q",           # flake8-quotes
-  "RET",         # flake8-return
-  "RSE",         # flake8-raise
-  "RUF",         # Ruff-specific
-  "SIM",         # flake8-simplify
-  "SLOT",        # flake8-slots
-  "T10",         # flake8-debugger
-  "T20",         # flake8-print
-  "TC",          # flake8-type-checking
-  "TID251",      # flake8-tidy-imports.banned-api
-  "TRY",         # tryceratops
-  "UP",          # pyupgrade
-  "YTT",         # flake8-2020
-
-]
+extend-select = ["ALL"]
 ignore = [
-  "ISC001",  # May collide with formatter
   "PLR09",   # Too many X
   "PLR2004", # Magic value in comparison
+  "COM812",  # Trailing commas teach the formatter
+  "E501",    # Line too long
+  "S101",    # Assert is used by pytest and mypy
+  "D",       # TODO
+  "C9",      # Complexity
+  "S",       # TODO
+  "ANN401",  # TODO (Any)
 ]
 typing-modules = ["repo_review._compat.typing"]
+pydocstyle.convention = "pep257"
+flake8-builtins.ignorelist = ["copyright", "print"]
 
 [tool.ruff.lint.flake8-tidy-imports.banned-api]
 "typing.Callable".msg = "Use collections.abc.Callable instead."
@@ -267,7 +238,9 @@ typing-modules = ["repo_review._compat.typing"]
 
 [tool.ruff.lint.per-file-ignores]
 "src/repo_review/_compat/**.py" = ["TID251"]
-"src/**/__main__.py" = ["T20"]
+"src/**/__main__.py" = ["T20", "FBT001"]
+"tests/**.py" = ["D", "INP001", "FBT001", "ANN"]
+"docs/**.py" = ["INP001"]
 
 [tool.coverage]
 report.exclude_also = [

src/repo_review/__main__.py

@@ -206,14 +206,14 @@ def rich_printer(
             console.print("[bold green]All checks passed [yellow](with some skips)")
 
     if svg:
-        str = console.export_svg(theme=rich.terminal_theme.DEFAULT_TERMINAL_THEME)
+        string = console.export_svg(theme=rich.terminal_theme.DEFAULT_TERMINAL_THEME)
         if color:
             rich.print(
-                rich.syntax.Syntax(str, lexer="xml"),
+                rich.syntax.Syntax(string, lexer="xml"),
                 file=sys.stderr if stderr else sys.stdout,
             )
         else:
-            print(str, file=sys.stderr if stderr else sys.stdout)
+            print(string, file=sys.stderr if stderr else sys.stdout)
 
 
 def display_output(

src/repo_review/checks.py

@@ -139,7 +139,9 @@ def get_check_description(name: str, check: Check) -> str:
 
 
 def process_result_bool(
-    result: str | bool | None, check: Check, name: str
+    result: str | bool | None,  # noqa: FBT001
+    check: Check,
+    name: str,
 ) -> str | None:
     """
     This converts a bool into a string given a check and name. If the result is a string

src/repo_review/families.py

@@ -42,7 +42,6 @@ def collect_families(fixtures: Mapping[str, Any]) -> dict[str, Family]:
 
     :param fixtures: Fully evaluated dict of fixtures.
     """
-
     family_functions = (
         ep.load()
         for ep in importlib.metadata.entry_points(group="repo_review.families")

src/repo_review/fixtures.py

@@ -54,7 +54,6 @@ def list_all(root: Traversable) -> bool:
 
     .. versionadded:: 0.8
     """
-
     return isinstance(root, EmptyTraversable)
 
 

src/repo_review/ghpath.py

@@ -50,7 +50,7 @@ class GHPath(Traversable):
 
     @staticmethod
     def open_url(url: str) -> io.StringIO:
-        "This method can be overridden manually for WASM. Supports pyodide currently."
+        """This method can be overridden manually for WASM. Supports pyodide currently."""
         if sys.platform == "emscripten":
             import pyodide.http  # noqa: PLC0415
 

src/repo_review/schema.py

@@ -17,7 +17,7 @@ def __dir__() -> list[str]:
 
 
 def get_schema(tool_name: str = "repo-review") -> dict[str, Any]:
-    "Get the stored complete schema for repo-review settings."
+    """Get the stored complete schema for repo-review settings."""
     assert tool_name == "repo-review", "Only repo-review is supported."
 
     with resources.joinpath("repo-review.schema.json").open(encoding="utf-8") as f:

src/repo_review/testing.py

@@ -44,7 +44,6 @@ def compute_check(name: str, /, **fixtures: Any) -> Result:
 
     .. versionadded:: 0.10.5
     """
-
     check_functions = (
         ep.load() for ep in importlib.metadata.entry_points(group="repo_review.checks")
     )

tests/test_utilities/pyproject.py

@@ -5,9 +5,6 @@
 if TYPE_CHECKING:
     from repo_review._compat.importlib.resources.abc import Traversable
 
-# PP: PyProject.toml
-## PP0xx: Build system
-
 
 class General:
     family = "general"