Custom message type for compiletime.error #15793
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes summonInline behavior in scala#15788
Contributor
|
This should be for @nicolasstucki (or anybody else who volunteers to cover this) to review. But I am pretty sure The fact that this PR does not break any tests means nothing. Error diagnostics is severly under-tested. |
Contributor
|
Superseded by #22561 which tries to have a smaller footprint and also follows in the footsteps of a similar effort to smuggle out macro errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes summonInline behavior in #15788
The fix is perhaps of a "hacky" kind. But it fixes the original issue described in #15788 and does not break any existing test.
Perhaps we need more generic way to distinguish error cases that mean "given instance not found" from "it was found but we have some error that should be reported to the user".