Relax flow typing checks on FlexibleTypes

Author: HarrisL2

compiler/src/dotty/tools/dotc/core/Types.scala

@@ -382,7 +382,7 @@ object Types extends TypeUtils {
     /** Is this type guaranteed not to have `null` as a value? */
     final def isNotNull(using Context): Boolean = this match {
       case tp: ConstantType => tp.value.value != null
-      case tp: FlexibleType => true
+      case tp: FlexibleType => false
       case tp: ClassInfo => !tp.cls.isNullableClass && !tp.isNothingType
       case tp: AppliedType => tp.superType.isNotNull
       case tp: TypeBounds => tp.hi.isNotNull

library/src/scala/reflect/Selectable.scala

@@ -23,7 +23,7 @@ trait Selectable extends scala.Selectable:
   final def selectDynamic(name: String): Any =
     val rcls = selectedValue.getClass
     try
-      val fld = rcls.getField(NameTransformer.encode(name)).nn
+      val fld = rcls.getField(NameTransformer.encode(name))
       ensureAccessible(fld)
       fld.get(selectedValue)
     catch case ex: NoSuchFieldException =>
@@ -37,7 +37,7 @@ trait Selectable extends scala.Selectable:
    */
   final def applyDynamic(name: String, paramTypes: Class[?]*)(args: Any*): Any =
     val rcls = selectedValue.getClass
-    val mth = rcls.getMethod(NameTransformer.encode(name), paramTypes*).nn
+    val mth = rcls.getMethod(NameTransformer.encode(name), paramTypes*)
     ensureAccessible(mth)
     mth.invoke(selectedValue, args.asInstanceOf[Seq[AnyRef]]*)
 

library/src/scala/util/FromDigits.scala

@@ -154,7 +154,7 @@ object FromDigits {
         case ex: NumberFormatException => throw MalformedNumber()
       }
     if (x.isInfinite) throw NumberTooLarge()
-    if (x == 0.0d && !zeroFloat.pattern.matcher(digits).nn.matches) throw NumberTooSmall()
+    if (x == 0.0d && !zeroFloat.pattern.matcher(digits).matches) throw NumberTooSmall()
     x
   }
 

presentation-compiler/src/main/dotty/tools/pc/AutoImports.scala

@@ -23,7 +23,7 @@ object AutoImports:
     def renameConfigMap(config: PresentationCompilerConfig)(using
         Context
     ): Map[Symbol, String] =
-      config.symbolPrefixes().nn.asScala.flatMap { (from, to) =>
+      config.symbolPrefixes().asScala.flatMap { (from, to) =>
         val pkg = SemanticdbSymbols.inverseSemanticdbSymbol(from)
         val rename = to.stripSuffix(".").stripSuffix("#")
         List(pkg, pkg.map(_.moduleClass)).flatten
@@ -253,7 +253,7 @@ object AutoImports:
         // see WorksheetProvider.worksheetScala3AdjustmentsForPC
         val indent =
           if pos.source.path.isWorksheet &&
-            editPos.getStart().nn.getCharacter() == 0
+            editPos.getStart().getCharacter() == 0
           then indent0.drop(2)
           else indent0
         val topPadding =

presentation-compiler/src/main/dotty/tools/pc/AutoImportsProvider.scala

@@ -30,8 +30,8 @@ final class AutoImportsProvider(
 )(using ReportContext):
 
   def autoImports(isExtension: Boolean): List[AutoImportsResult] =
-    val uri = params.uri().nn
-    val text = params.text().nn
+    val uri = params.uri()
+    val text = params.text()
     val filePath = Paths.get(uri)
     driver.run(uri, SourceFile.virtual(filePath.toString, text))
 

presentation-compiler/src/main/dotty/tools/pc/CompilerSearchVisitor.scala

@@ -19,7 +19,7 @@ class CompilerSearchVisitor(
 )(using ctx: Context, reports: ReportContext)
     extends SymbolSearchVisitor:
 
-  val logger: Logger = Logger.getLogger(classOf[CompilerSearchVisitor].getName()).nn
+  val logger: Logger = Logger.getLogger(classOf[CompilerSearchVisitor].getName())
 
   private def isAccessibleImplicitClass(sym: Symbol) =
     val owner = sym.maybeOwner
@@ -77,7 +77,7 @@ class CompilerSearchVisitor(
       .split("\\$")
 
     val added =
-      try toSymbols(pkg, innerPath.nn.toList.map(_.nn)).filter(visitSymbol)
+      try toSymbols(pkg, innerPath.toList).filter(visitSymbol)
       catch
         case NonFatal(e) =>
           logger.log(Level.WARNING, e.getMessage(), e)

presentation-compiler/src/main/dotty/tools/pc/CompletionItemResolver.scala

@@ -50,7 +50,7 @@ object CompletionItemResolver extends ItemResolver:
       Context
   ): String =
     def docs(gsym: Symbol): String =
-      search.symbolDocumentation(gsym).fold("")(_.docstring().nn)
+      search.symbolDocumentation(gsym).fold("")(_.docstring())
     val gsymDoc = docs(gsym)
     def keyword(gsym: Symbol): String =
       if gsym.isClass then "class"

presentation-compiler/src/main/dotty/tools/pc/ConvertToNamedArgumentsProvider.scala

@@ -23,8 +23,8 @@ final class ConvertToNamedArgumentsProvider(
 ):
 
   def convertToNamedArguments: Either[String, List[l.TextEdit]] =
-    val uri = params.uri().nn
-    val text = params.text().nn
+    val uri = params.uri()
+    val text = params.text()
     val filePath = Paths.get(uri)
     driver.run(uri, SourceFile.virtual(filePath.toString, text))
 

presentation-compiler/src/main/dotty/tools/pc/DiagnosticProvider.scala

@@ -18,7 +18,7 @@ class DiagnosticProvider(driver: InteractiveDriver, params: VirtualFileParams):
 
   def diagnostics(): List[lsp4j.Diagnostic] =
     if params.shouldReturnDiagnostics then
-      val diags = driver.run(params.uri().nn, params.text().nn)
+      val diags = driver.run(params.uri(), params.text())
       given Context = driver.currentCtx
       diags.flatMap(toLsp)
     else Nil

presentation-compiler/src/main/dotty/tools/pc/ExtractMethodProvider.scala

@@ -39,8 +39,8 @@ final class ExtractMethodProvider(
     extends ExtractMethodUtils:
 
   def extractMethod(): List[TextEdit] =
-    val text = range.text().nn
-    val uri = range.uri().nn
+    val text = range.text()
+    val uri = range.uri()
     val filePath = Paths.get(uri)
     val source = SourceFile.virtual(filePath.toString, text)
     driver.run(uri, source)