Remove duplicate TypeDef::isAliasFor method

Author: kornilova203

bindgen/Utils.h

@@ -116,11 +116,14 @@ static inline std::string replaceChar(const std::string &str,
  * @return true if given type is of type T or is an alias for type T.
  */
 template <typename T> static inline bool isAliasForType(Type *type) {
-    if (isInstanceOf<TypeDef>(type)) {
-        auto *typeDef = dynamic_cast<TypeDef *>(type);
+    if (isInstanceOf<T>(type)) {
+        return true;
+    }
+    auto *typeDef = dynamic_cast<TypeDef *>(type);
+    if (typeDef) {
         return isAliasForType<T>(typeDef->getType().get());
     }
-    return isInstanceOf<T>(type);
+    return false;
 }
 
 #endif // UTILS_H

bindgen/ir/Function.cpp

@@ -74,19 +74,15 @@ Function::~Function() {
 }
 
 bool Function::isLegalScalaNativeFunction() const {
-    /* structs and unions are used only through corresponding TypeDefs so it's
-     * okay to cast only to TypeDef.
-     * Return type and parameters types cannot be array types because array type
+    /* Return type and parameters types cannot be array types because array type
      * in this case is always represented as a pointer to element type */
-    auto *typeDef = dynamic_cast<TypeDef *>(retType.get());
-    if (typeDef &&
-        (typeDef->isAliasFor<Struct>() || typeDef->isAliasFor<ArrayType>())) {
+    if (isAliasForType<Struct>(retType.get()) ||
+        isAliasForType<Union>(retType.get())) {
         return false;
     }
     for (const auto &parameter : parameters) {
-        typeDef = dynamic_cast<TypeDef *>(parameter->getType().get());
-        if (typeDef && (typeDef->isAliasFor<Struct>() ||
-                        typeDef->isAliasFor<ArrayType>())) {
+        if (isAliasForType<Struct>(parameter->getType().get()) ||
+            isAliasForType<Union>(parameter->getType().get())) {
             return false;
         }
     }

bindgen/ir/TypeDef.h

@@ -23,27 +23,6 @@ class TypeDef : public TypeAndName, public Type {
 
     std::shared_ptr<Location> getLocation() const;
 
-    /**
-     * @tparam T Type
-     * @return true if the typedef is an alias for give type directly or through
-     * a chain of typedefs
-     */
-    template <typename T> bool isAliasFor() const {
-        /* if body is moved to cpp file then linker gives undefined symbols
-         * error */
-        if (!type) {
-            return false;
-        }
-        if (dynamic_cast<T *>(type.get())) {
-            return true;
-        }
-        auto *typeDef = dynamic_cast<TypeDef *>(type.get());
-        if (typeDef) {
-            return typeDef->isAliasFor<T>();
-        }
-        return false;
-    }
-
   private:
     /**
      * nullptr if type is generated.